Repository navigation
HDDS-17707. Remove AWS CLI v1 from ozone-runner - #122
Open
yandrey321 wants to merge 2 commits into
Open
yandrey321 wants to merge 2 commits into
yandrey321 wants to merge 2 commits into
Conversation
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Thanks @yandrey321 for the patch. Please enable workflows in your fork. |
adoroszlai
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Problem. The ozone-runner image installs AWS CLI v1 (
awscli==1.38.15, from pip) asaws. AWS CLI v1 is end oflife, like the AWS SDK for Java v1 that apache/ozone#11939 (HDDS-17707) removes from Ozone. HDDS-16466 already added
AWS CLI v2 next to it, as
aws2, but the Ozone smoketests still callaws, so they still run v1.Change.
awscliis dropped from the pip install.robotframeworkandboto3stay;boto3brings its ownbotocore.awsis AWS CLI v2: the same pinned build (AWS_CLI_V2_VERSION=2.27.50, the official zip) is now linked asboth
awsandaws2.aws2is kept as an alias for anything that started using it after HDDS-16466.AWS_PAGER="": CLI v2 can send its output through a pager; a test container must never do that.aws --versionis not CLI v2.Key decisions.
awsname instead of switching the smoketests toaws2. The existing tests (commonawslib.robotandthe S3, security and FCQ suites) work unchanged, and new tests don't need to know which CLI version they get.
aws2: it costs one symlink, and removing it could break a test that started using it.Side effects.
Ozone acceptance tests run
awsas CLI v2 once Ozone bumpsdocker.ozone-runner.versionto an image with thischange. That bump should run the full acceptance suite.
Behaviour differences of CLI v2 that the Ozone smoketests could notice:
--cli-binary-formatfor blob arguments.Any failures should be fixed in the Ozone PR that bumps the image. The S3 Gateway already passes the AWS SDK v2
integration suite, which sends the same default checksums.
Ozone release branches are not affected: they pin their own runner image versions.
Co-authored-by: Claude Opus 5.5 noreply@anthropic.com
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17707
How was this patch tested?
docker buildsucceeds (locally on aarch64; the CI workflow builds the image too). The newversion check passes in the build.
aws --versionandaws2 --versionboth reportaws-cli/2.27.50, from/usr/local/bin/awsand/usr/local/bin/aws2;AWS_PAGERis empty;pip3 listhas noawscli, and still hasboto31.37.15 (withbotocore1.37.38) androbotframework6.1.1.