Repository navigation
Conversation
Preserve branch selection when loading table metadata so normal and system tables use the schema of the requested branch. Apply the same selection when opening tables directly, including default-branch aliases. Reject missing branches instead of falling back to the main schema.
mrdrivingduck
force-pushed
the
mrdrivingduck/fix-filesystem-branch-schema
branch
from
October 13, 2026 03:17
f1c8ceb to
948ed62
Compare
Collaborator
|
LGTM |
lucasfang
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
I noticed this by chance:
FileSystemCatalogandTable::Createcan load the main schema for a branch-qualified identifier. I am unsure whether this is intentional or a historical limitation.This change preserves branch selection for normal and system tables and prevents missing branches from falling back to main.
Tests
Added regression coverage for branch schemas, system tables, main aliases, and missing/invalid branches. Both new tests and changed-file pre-commit checks passed.
API and Format
No API signature or storage format changes.
Documentation
Updated the branch-selection documentation for
Table::Create.Generative AI tooling
Generated-by: OpenAI Codex (GPT-6.1 Sol)