Repository navigation
fix(executor): do not retain callbacks when worker startup fails - #437
Open
realAaronWu wants to merge 4 commits into
Open
realAaronWu wants to merge 4 commits into
realAaronWu wants to merge 4 commits into
Conversation
added 4 commits
October 16, 2026 06:37
Author
|
Local validation and isolated internal review are complete. The public workflows are awaiting maintainer approval; could you please approve their execution? This remains a validation draft until the applicable CI checks complete. |
lxy-9602
marked this pull request as ready for review
October 16, 2026 05:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #436. Related to #435, but does not implement planning cancellation or budgets.
DefaultExecutor::Addcurrently queues its callback before lazy worker startup. If startup throws, a later submission can run the callback whose submission failed.Start workers under the existing mutex before enqueueing the callback. A failed invocation releases its captures immediately; partial worker startup can leave idle workers and does not restore the configured worker count on retry.
Tests
RelWithDebInfo new/common targets also passed. Its wider build hit an unchanged GCC 15
-O2 -Werror=maybe-uninitializedwarning inremote_lookup_file_manager_test.cpp; the identical compile fails on main too. Debug wider targets above completed without suppressing that warning or changing unrelated code.API and Format
No public API or storage-format change. Custom executors, general
ShutdownNowallocation-failure safety, and complete pool rollback are outside this fix.Documentation
No new user-facing feature. The implementation comment explains the submission boundary.
Generative AI tooling
Generated-by: OpenAI Codex (desktop; model/version not exposed).