Skip to content

chore(build): use one Rust toolchain for all FFI builds - #439

Open
zhouyc-ali wants to merge 1 commit into
apache:mainfrom
zhouyc-ali:chore/unify-rust-toolchain
Open

zhouyc-ali wants to merge 1 commit into
apache:mainfrom
zhouyc-ali:chore/unify-rust-toolchain

Conversation

@zhouyc-ali

Copy link
Copy Markdown
Contributor

Purpose

Linked issue: N/A (follow-up to #376, which introduced the Vortex format together with a
separate stable Rust channel for its FFI build)

Unify every Rust FFI build (Lance, Mosaic, Vortex and the full-text index) on the single
pinned toolchain 1.95.0, instead of installing an extra stable channel only for Vortex.
The Vortex cargo invocation now selects the pinned toolchain explicitly, which overrides
the rust-toolchain.toml shipped inside the Vortex archive (channel 1.91.0).

Tests

  • cargo check --locked --release -p vortex-ffi on the pinned Vortex source tree passes
    with rustc 1.91.0 and with 1.95.0.
  • Full build with the unified toolchain: 0 errors / 0 warnings; ctest -L unittest 33/33.
  • Lance is disabled in the local build; the gcc8 / sanitizer / aarch64 matrix is left to CI.

API and Format

No.

Documentation

No.

Generative AI tooling

Generated-by: Qoder

Bump the pinned Rust toolchain to 1.95.0 and drop the separate stable channel
that only the Vortex FFI build used. The Vortex cargo invocation now selects
the pinned toolchain explicitly, which overrides the rust-toolchain.toml
shipped inside the Vortex archive, so Lance, Mosaic, Vortex and the full-text
index all build with a single toolchain.

@zjw1111 zjw1111 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

zjw1111

This comment was marked as outdated.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants