Repository navigation
perf(core): reuse immutable ROW sidecar file sizes - #1195
Open
XiaoHongbo-Hope wants to merge 3 commits into
Open
XiaoHongbo-Hope wants to merge 3 commits into
XiaoHongbo-Hope wants to merge 3 commits into
Conversation
Contributor
|
How does this relate to #1196? Why is it necessary to handle this separately? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Each sparse Data Evolution read that selects an immutable ROW sidecar calls object storage
statto learn the sidecar length, even when the same file is queried repeatedly. This adds a remote request before the ROW reader can seek to its footer.Change
Cache the size of registered ROW sidecars in the existing FileIO metadata-cache context. Keys use the storage namespace and canonical object path, so distinct storage targets cannot share a cached size. The cache is bounded to 4,096 entries, is disabled when the metadata cache is disabled or the provider has no stable namespace, bypasses inherited state after fork, and is invalidated on FileIO file/directory deletion. No public option or file-format change is introduced.
Validation
cargo test --locked -p paimon test_immutable_row_sidecar_size_cache_is_scoped_and_disabled_with_metadata_cache --features storage-memory --libcargo test --locked -p paimon --test data_evolution_row_sidecar_test(14 passed)cargo clippy --locked -p paimon --lib --features storage-memory -- -D warningscargo fmt --all -- --check;git diff --checkThis PR optimizes the existing ROW sidecar path. It does not add the separate scalar
.srowformat used in the DROID prototype.