Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PR #1198 moved
partition_key()out oftable_upsert.rsbut left theBinaryRowimport at module scope. Its remaining uses are inside thetest module, so non-test builds report an unused import. CI treats this
warning as an error through
-D warnings.Move the import into the test module to fix the warning.
Brief change log
BinaryRowfrom the module-level imports intable_upsert.rs.BinaryRowdirectly inside the existing#[cfg(test)]module.Tests
Verified the fix locally in a temporary source copy:
cargo clippy --offline --locked -p paimon --lib -- -D warningsfails with an unused
BinaryRowimport (exit code 101).cargo clippy --offline --locked -p paimon --lib --tests -- -D warningspasses (exit code 0).
The following checks also passed:
cargo fmt --all -- --checkgit diff --checkClippy checked both the library and test targets. Runtime tests were not
executed because this change only relocates an import.
API and Format
No public API or persisted data format changes. Upsert behavior and test
logic remain unchanged.
Documentation
No documentation changes required.