Skip to content

[api] Use Locale.ROOT in DLFOpenApiV4Signer #10087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Sep 24, 2026
Merged

[api] Use Locale.ROOT in DLFOpenApiV4Signer #10087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion paimon-api/src/main/java/org/apache/paimon/rest/auth/DLFOpenApiV4Signer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.UUID;

Expand Down Expand Up @@ -252,7 +253,7 @@ private static CanonicalHeadersResult buildCanonicalHeaders(Map<String, String>
Map<String, String> valueMap = new HashMap<>();

for (Map.Entry<String, String> entry : headers.entrySet()) {
String lowerKey = entry.getKey().toLowerCase();
String lowerKey = entry.getKey().toLowerCase(Locale.ROOT);
if (lowerKey.startsWith("x-acs-")
|| lowerKey.equals(HOST_HEADER)
|| lowerKey.equals(CONTENT_TYPE_HEADER)) {
Expand Down
22 changes: 22 additions & 0 deletions paimon-api/src/test/java/org/apache/paimon/rest/auth/DLFOpenApiV4SignerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.time.ZonedDateTime;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Locale;
import java.util.Map;

import static org.junit.jupiter.api.Assertions.assertEquals;
Expand Down Expand Up @@ -164,6 +165,27 @@ public void testDeterministicSignature() throws Exception {
assertEquals(auth1, auth2);
}

@Test
public void testAuthorizationWithTurkishLocale() throws Exception {
Locale originalLocale = Locale.getDefault();
try {
Locale.setDefault(Locale.US);
DLFOpenApiV4Signer signer = new DLFOpenApiV4Signer(REGION);
DLFToken token = new DLFToken("TestAKId", "TestAKSecret", null, null);
RESTAuthParameter restAuthParameter =
new RESTAuthParameter("/test/path", new HashMap<>(), "GET", null);
Map<String, String> headers = signer.signHeaders(null, NOW, null, HOST);
headers.put("x-acs-signature-nonce", "fixed-nonce-for-test");
headers.put("X-ACS-SIGNATURE-NONCE", headers.remove("x-acs-signature-nonce"));

String expected = signer.authorization(restAuthParameter, token, HOST, headers);
Locale.setDefault(new Locale("tr", "TR"));
assertEquals(expected, signer.authorization(restAuthParameter, token, HOST, headers));
} finally {
Locale.setDefault(originalLocale);
}
}

@Test
public void testSignatureCoversQueryParameters() throws Exception {
DLFOpenApiV4Signer signer = new DLFOpenApiV4Signer(REGION);
Expand Down
Loading