Repository navigation
Conversation
Format Table reads pass filters indexed against the full table row type together with a data row type that excludes partition columns. MosaicRecordsReader evaluated row-group stats by field index, so a partition column declared before the filtered column made the filter read another column's stats: matching row groups were skipped or the read failed with ArrayIndexOutOfBoundsException when mosaic.stats-columns was set. Remap filters by name against the file row type, as Parquet and ORC already do. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #10727
MosaicRecordsReadernow remaps filters by name against the file row type withPredicateRemapper; a conjunct that cannot be resolved is dropped, which only relaxes row-group pruning.mosaic.stats-columnsand a partition column before the filtered column, row groups were wrongly skipped (no rows) or the read hitArrayIndexOutOfBoundsException. Defaults are unaffected.FormatReadBuilderinstead would miss the PK key-value layout (MergeFileSplitReadnotes formats resolve by name).Tests
FormatTableMosaicReadTest#testFilterOnDataColumnAfterPartitionColumn(a = 1,b = 101,a >= 105) and#testFilterOnColumnWithoutStatsAfterPartitionColumn. Before the fix: no rows /ArrayIndexOutOfBoundsException/ no pruning.mvn -pl paimon-mosaic clean install: 160 tests, 0 failures.