Repository navigation
Conversation
The native Mosaic writer updates FLOAT/DOUBLE min/max with a partial comparison: a leading NaN pins both bounds to NaN, a later NaN never enters the bounds, and -0.0 equals +0.0. Paimon compares bounds with compareTo, so manifest pruning and row-group pruning could skip files and row groups that still contain matching rows. Mosaic stats carry no NaN count, so such bounds cannot be detected and are no longer used. Null counts are kept. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #10728
mosaic.stats-columns; the default collects no stats.fileformat.md), losing min/max pruning.Tests
MosaicFloatingPointBoundsTest: table reads with NaN-first and signed-zero rows (FLOAT and DOUBLE), asserting the planned split, the row-group read and the filtered result. Red on master at both levels, green now. Single row group only; engine SQL not run.MosaicSimpleStatsExtractorTestexpectations.mvn -pl paimon-mosaic clean install: 162 tests, 0 failures.