Repository navigation
[flink] Restore @Test on RESTCatalogITCase#testExpiredDataToken - #10736
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
The annotation was dropped in apache#7034 together with the one on testColumnMasking. apache#7069 put it back on testColumnMasking, but testExpiredDataToken has not run since, so nothing checks that a write with an expired data token fails and succeeds again once the server hands out a fresh token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#7034 removed the
@Testannotation fromtestExpiredDataTokenandtestColumnMasking, and #7069 put it back ontestColumnMaskingonly. Since then nothing checks that a write with an expired data token fails, and that it works again once the REST server hands out a fresh token. This restores the annotation.Tests
RESTCatalogITCasepasses with 11 tests. The test fails if the token given to the client is not actually expired.