Conversation
nastra
commented
Sep 14, 2026
|
|
||
| private Schema.Field getAvroField(String parquetFieldName) { | ||
| Schema.Field avroField = avroSchema.getField(parquetFieldName); | ||
| if (avroField != null) { |
Contributor
Author
There was a problem hiding this comment.
this also aligns with how AvroRecordConverter does it. I also checked other places in the codebase and that seems to be the only one affected
nastra
commented
Sep 14, 2026
| import org.junit.jupiter.params.ParameterizedTest; | ||
| import org.junit.jupiter.params.provider.ValueSource; | ||
|
|
||
| public class TestAvroFieldNameAndAlias { |
Contributor
Author
There was a problem hiding this comment.
there wasn't a good fit for this in existing tests, so I decided to create a separate class
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This makes sure that the actual Avro field name is considered before looking at aliases.
Fixes #3792
What changes are included in this PR?
Are these changes tested?
yes
Are there any user-facing changes?
no