Prepare RC: use the repositories API to verify staged artifacts - #3794
Merged
rdblue merged 1 commit intoSep 14, 2026
Merged
Conversation
nexus_check_staging_artifact built URLs under /content/repositories/<id>/, which does not serve open staging repositories. The check therefore failed for every RC: prepare-rc.sh runs it before closing, so the repo is always open at that point. 1.19.0-rc8 aborted this way even though the staging repo was correct and complete. Confirmed by probing repository.apache.org: /content/repositories/<id>/... returned 404 anonymously, with a committer user token, and with the deployer service account, while /service/local/repositories/<id>/content/... returned 200. Closing the repo by hand flipped /content/repositories/ to 200, confirming it only serves closed repos. Switch to the repositories API, which serves a staging repo in both states. That matters because this function has call sites on both sides of the close: prepare-rc.sh checks pre-close (open), while cancel-rc.sh and publish-release.sh reach it via nexus_verify_staging_repo post-close (closed). Neither of those had run against real Nexus, so both carried the same latent failure. Verified against a live staging repo in both states, and end-to-end by running cancel-rc.sh against a closed repo, which also exercised nexus_get_staging_repo_metadata and nexus_drop_staging_repo for the first time. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rdblue
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We were validating the Staging artifacts behind the wrong URL. This was causing the verification post push to fail.
What changes are included in this PR?
URL was corrected
Are these changes tested?
Yes! Because i have access to Nexus independently I checked that both the new urls worked and I verified that our cancel action worked.
Are there any user-facing changes?
No