Document and test table name override on segment push - #19085
Open
Vamsi-klu wants to merge 1 commit into
Open
Conversation
Operators already can push a segment tar into a different table via the tableName request parameter, but metadata mismatch was opaque. Log override clearly, document CLI -tableName, and cover staging-to-prod upload in tests.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19085 +/- ##
============================================
+ Coverage 65.47% 65.49% +0.02%
Complexity 1421 1421
============================================
Files 3426 3426
Lines 217315 217324 +9
Branches 34509 34511 +2
============================================
+ Hits 142283 142341 +58
+ Misses 63513 63471 -42
+ Partials 11519 11512 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
| String rawTableName = TableNameBuilder.extractRawTableName(requestTableName); | ||
| if (StringUtils.isNotEmpty(metadataTableName)) { | ||
| String metadataRawTableName = TableNameBuilder.extractRawTableName(metadataTableName); | ||
| if (!rawTableName.equals(metadataRawTableName)) { |
Contributor
There was a problem hiding this comment.
Suggest keeping the original logic. The goal is to decouple table name from segment metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Data engineers often build segments once and promote staging → prod (or clone tables) without rebuilding. The controller already prefers the request
tableNameoversegment.table.namein metadata, but that override was under-documented and easy to misuse when the param was omitted (silent fallback to baked metadata).Impact
-tableName/ query param is the override; metadata name is fallback only.How
-tableNameas override of bakedsegment.table.name.Test plan
PinotSegmentUploadDownloadRestletResourceTest(or related) override coverage../mvnw -pl pinot-controller -am -Dtest=PinotSegmentUploadDownloadRestletResourceTest -Dsurefire.failIfNoSpecifiedTests=false testRelated
closes: #5427
Reviewers
Suggested: xiangfu0
Was generative AI tooling used to co-author this PR?
Generated-by: Grok Build (xAI)