Skip to content

Clarify subscription properties behavior #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhanglistar wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −5
Open

Clarify subscription properties behavior #594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions include/pulsar/ConsumerConfiguration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ class PULSAR_PUBLIC ConsumerConfiguration {
const std::string& getProperty(const std::string& name) const;

/**
* Get all the properties attached to this producer.
* Get all the properties attached to this consumer.
*/
std::map<std::string, std::string>& getProperties() const;

Expand All @@ -524,14 +524,17 @@ class PULSAR_PUBLIC ConsumerConfiguration {
ConsumerConfiguration& setProperties(const std::map<std::string, std::string>& properties);

/**
* Get all the subscription properties attached to this subscription.
* Get all the subscription properties configured for this consumer.
*/
std::map<std::string, std::string>& getSubscriptionProperties() const;

/**
* Sets a new subscription properties for this subscription.
* Notice: SubscriptionProperties are immutable, and consumers under the same subscription will fail to
* create a subscription if they use different properties.
* Set subscription properties to send when creating or attaching to a subscription.
*
* If the subscription does not exist, the broker stores these properties when
* the subscription is created. If the subscription already exists, these
* properties do not update the existing subscription properties and the client
* does not validate them against the broker-side properties.
*
* @param subscriptionProperties all the subscription properties in the provided map
*/
Expand Down
Loading