Conversation
…mmand getConfigTypeList printed an "Invalid configType" message and returned null; execution then continued with the null list, so local mode threw a NullPointerException from Objects.requireNonNull and rpc mode carried the null into the export request. Throw a SubCommandException with the same message so the command aborts cleanly on a bad -t value.
RockteMQ-AI
approved these changes
Sep 11, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Clean fail-fast fix — throwing SubCommandException instead of returning null prevents the confusing NullPointerException downstream. The test explicitly verifies the NPE path is eliminated.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mqadmin rocksDBConfigToJsonwith a bad-tvalue printed an "Invalid configType" message and returnednullfromgetConfigTypeList, but execution then continued with the null list: local mode threw a rawNullPointerExceptionfromObjects.requireNonNull, and rpc mode carried the null list into the export request sent to brokers.Modifications
Throw a
SubCommandExceptioncarrying the same message so the command aborts cleanly on an invalid-tvalue instead of failing later with an unrelated error.Verification
Fail-before (new test, run against the unpatched code):
Pass-after: