Conversation
brokerId participates in hashCode but was missing from equals, so two configs for the same group that differ only in brokerId compared equal with different hash codes, breaking the Object contract for any HashSet/HashMap keyed on SubscriptionGroupConfig. Append brokerId to equals to match hashCode.
RockteMQ-AI
approved these changes
Sep 11, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Correct fix for the equals/hashCode contract violation. The test clearly demonstrates the bug (fail-before) and the fix (pass-after).
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
brokerIdparticipates inSubscriptionGroupConfig.hashCodebut was missing fromequals, so two configs for the same group that differ only inbrokerIdcompared equal while hashing differently — breaking theObjectcontract for anyHashSet/HashMapkeyed onSubscriptionGroupConfig(lookups miss, set dedup misbehaves).Modifications
Append
brokerIdtoequalsto matchhashCode.Verification
Fail-before (new test, run against the unpatched code):
Pass-after: