Conversation
…romEndpoint
parseInstanceIdFromEndpoint used the result of endpoint.indexOf('.')
directly as the substring end index, so any non-empty endpoint without a
dot (for example "MQ_INST_123456789_BXXUzaee:80") produced -1 and threw
StringIndexOutOfBoundsException from a public utility. Treat a missing
dot as a non-instance endpoint and return null.
RockteMQ-AI
approved these changes
Sep 11, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Fix parseInstanceIdFromEndpoint to handle endpoints without a dot, returning null instead of throwing StringIndexOutOfBoundsException.
LGTM — clean defensive fix with test.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
parseInstanceIdFromEndpointused the result ofendpoint.indexOf('.')directly as the substring end index:so any non-empty endpoint without a dot (for example
MQ_INST_123456789_BXXUzaee:80) produced-1and threwStringIndexOutOfBoundsExceptionfrom a public utility.Modifications
Treat a missing dot as a non-instance endpoint and return null.
Verification
Fail-before (new test, run against the unpatched code):
Pass-after: