Conversation
receiveMessage feeds settings.getBackoffPolicy().getMaxAttempts() into PopMessageResultFilterImpl. When a client leaves the backoff policy unset, proto3 defaults maxAttempts to 0, and while the subscription group config is unavailable (mergeSubscriptionData passes the raw client settings through on a config miss) every popped message, including its first delivery, hit reconsumeTimes >= 0 and was routed straight to the DLQ. Clamp maxAttempts to at least 1 in the filter so a message always gets one delivery attempt before the DLQ verdict.
RockteMQ-AI
approved these changes
Sep 11, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Clamp maxAttempts to at least 1 in PopMessageResultFilterImpl, ensuring that clients with proto3 default (0) backoff policy still get at least one delivery attempt before messages go to the DLQ.
LGTM — correct proto3 edge case handling with thorough test.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
receiveMessagefeedssettings.getBackoffPolicy().getMaxAttempts()intoPopMessageResultFilterImpl. When a client leaves the backoff policy unset, proto3 defaultsmaxAttemptsto 0, and while the subscription group config is unavailable (mergeSubscriptionDatapasses the raw client settings through on a config miss) every popped message — including its first delivery — hitreconsumeTimes >= maxAttemptsand was routed straight to the DLQ.Modifications
Clamp
maxAttemptsto at least 1 in the filter, so a message always gets one delivery attempt before the DLQ verdict.Verification
Fail-before (new test, run against the unpatched code):
Pass-after: