Conversation
A typo in the required -c option made clusterAddrTable.get(clusterName) return null and the for-each threw a raw NullPointerException. Print a 'cluster not exist' error like the sibling cluster commands do.
RockteMQ-AI
approved these changes
Sep 11, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Add null check for brokerNameSet in exportMetrics when the requested cluster does not exist, printing a clear error message instead of NPE.
LGTM — defensive null guard with test.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A typo in the required
-coption ofmqadmin exportMetricsmadeclusterAddrTable.get(clusterName)return null, and the following for-each threw a rawNullPointerExceptionfrom inside the command, producing a stack trace instead of an error message.Modifications
Print a
cluster not existerror like the sibling cluster commands do.Verification
Fail-before (new test, run against the unpatched code):
Pass-after: