Skip to content

fix(remoting): report version 0 for consumer groups without connections #11148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zjncs wants to merge 1 commit into
base: develop
Choose a base branch
from
+10 −0
Open

fix(remoting): report version 0 for consumer groups without connections #11148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions remoting/src/main/java/org/apache/rocketmq/remoting/protocol/body/ConsumerConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ public class ConsumerConnection extends RemotingSerializable {
private ConsumeFromWhere consumeFromWhere;

public int computeMinVersion() {
if (this.connectionSet.isEmpty()) {
return 0;
}
int minVersion = Integer.MAX_VALUE;
for (Connection c : this.connectionSet) {
if (c.getVersion() < minVersion) {
Expand Down
7 changes: 7 additions & 0 deletions ...ting/src/test/java/org/apache/rocketmq/remoting/protocol/body/ConsumerConnectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,11 @@ public void testComputeMinVersion() {
int version = consumerConnection.computeMinVersion();
assertThat(version).isEqualTo(1);
}

@Test
public void testComputeMinVersionWithNoConnection() {
// a group without live connections must not be reported as HighestVersion
ConsumerConnection consumerConnection = new ConsumerConnection();
assertThat(consumerConnection.computeMinVersion()).isEqualTo(0);
}
}