Term ooc covariance tsmm#2494
Open
122Astha wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the initial OOC covariance test setup for cov(A, B). The test creates dense and sparse vector inputs, runs the covariance script once as the CP reference and once with -ooc, then compares the results.
Currently both dense and sparse OOC tests fail for the expected Week 1 reason: SystemDS generates an OOC cov instruction, but OOCInstructionParser does not support Covariance yet. The key error is: “Invalid OOC Instruction Type: Covariance”. This confirms the test-first setup is working and identifies the missing implementation/wiring.