test(frontend): add unit tests for FileSaverService by Ma77Ball · Pull Request #6460 · apache/texera

Ma77Ball · 2026-07-16T10:35:58Z

What changes were proposed in this PR?

Adds file-saver.service.spec.ts covering FileSaverService; no production code changed.
Verifies delegation to FileSaver.saveAs for Blob and string payloads.
Covers the case where filename and options are omitted (undefined is passed through).

Any related issues, documentation, discussions?

Closes: #6448

How was this PR tested?

Run cd frontend && npx nx test gui --include="**/file-saver.service.spec.ts", expect 4 passed.
Full frontend suite runs in CI via yarn test:ci, selected by the auto-applied frontend label.

Was this PR authored or co-authored using generative AI tooling?

Co-authored with Claude Opus 4.8 in compliance with ASF

github-actions · 2026-07-16T10:36:14Z

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

No candidates found from git blame history.

codecov-commenter · 2026-07-16T10:42:49Z

❌ 5 Tests Failed:

Tests completed	Failed	Passed	Skipped
3709	5	3704	2

View the top 3 failed test(s) by shortest run time

src/app/dashboard/service/user/file/file-saver.service.spec.ts > FileSaverService > propagates errors thrown by saveAs instead of swallowing them

Stack Traces | 0.00568s run time

AssertionError: expected function to throw an error, but it didn't
 ❯ .../user/file/file-saver.service.spec.ts:80:66
 ❯ src/test-zone-setup.ts:90:33
 ❯ _ZoneDelegate.invoke node_modules/zone.js/fesm2015/zone.js:398:28
 ❯ ProxyZoneSpec.onInvoke node_modules/zone.js/fesm2015/zone-testing.js:2132:39
 ❯ _ZoneDelegate.invoke node_modules/zone.js/fesm2015/zone.js:397:34
 ❯ ZoneImpl.run node_modules/zone.js/fesm2015/zone.js:113:43
 ❯ src/test-zone-setup.ts:88:16
 ❯ new ZoneAwarePromise node_modules/zone.js/fesm2015/zone.js:2701:25
 ❯ wrapper src/test-zone-setup.ts:86:16
 ❯ src/test-zone-setup.ts:90:33

src/app/dashboard/service/user/file/file-saver.service.spec.ts > FileSaverService > propagates errors thrown by saveAs

Stack Traces | 0.00636s run time

AssertionError: expected function to throw an error, but it didn't
 ❯ .../user/file/file-saver.service.spec.ts:63:57
 ❯ src/test-zone-setup.ts:90:33
 ❯ _ZoneDelegate.invoke node_modules/zone.js/fesm2015/zone.js:398:28
 ❯ ProxyZoneSpec.onInvoke node_modules/zone.js/fesm2015/zone-testing.js:2132:39
 ❯ _ZoneDelegate.invoke node_modules/zone.js/fesm2015/zone.js:397:34
 ❯ ZoneImpl.run node_modules/zone.js/fesm2015/zone.js:113:43
 ❯ src/test-zone-setup.ts:88:16
 ❯ new ZoneAwarePromise node_modules/zone.js/fesm2015/zone.js:2701:25
 ❯ wrapper src/test-zone-setup.ts:86:16
 ❯ src/test-zone-setup.ts:90:33

src/app/dashboard/service/user/file/file-saver.service.spec.ts > FileSaverService > passes undefined through when filename and options are omitted

Stack Traces | 0.00656s run time

AssertionError: expected "vi.fn()" to be called with arguments: [ Blob{ …(1) }, undefined, undefined ]

Number of calls: 0

 ❯ .../user/file/file-saver.service.spec.ts:71:20
 ❯ src/test-zone-setup.ts:90:33
 ❯ _ZoneDelegate.invoke node_modules/zone.js/fesm2015/zone.js:398:28
 ❯ ProxyZoneSpec.onInvoke node_modules/zone.js/fesm2015/zone-testing.js:2132:39
 ❯ _ZoneDelegate.invoke node_modules/zone.js/fesm2015/zone.js:397:34
 ❯ ZoneImpl.run node_modules/zone.js/fesm2015/zone.js:113:43
 ❯ src/test-zone-setup.ts:88:16

src/app/dashboard/service/user/file/file-saver.service.spec.ts > FileSaverService > delegates a Blob payload to saveAs with filename and options

Stack Traces | 0.00816s run time

AssertionError: expected "vi.fn()" to be called 1 times, but got 0 times
 ❯ .../user/file/file-saver.service.spec.ts:47:20
 ❯ src/test-zone-setup.ts:90:33
 ❯ _ZoneDelegate.invoke node_modules/zone.js/fesm2015/zone.js:398:28
 ❯ ProxyZoneSpec.onInvoke node_modules/zone.js/fesm2015/zone-testing.js:2132:39
 ❯ _ZoneDelegate.invoke node_modules/zone.js/fesm2015/zone.js:397:34
 ❯ ZoneImpl.run node_modules/zone.js/fesm2015/zone.js:113:43
 ❯ src/test-zone-setup.ts:88:16
 ❯ new ZoneAwarePromise node_modules/zone.js/fesm2015/zone.js:2701:25
 ❯ wrapper src/test-zone-setup.ts:86:16
 ❯ src/test-zone-setup.ts:90:33

src/app/dashboard/service/user/file/file-saver.service.spec.ts > FileSaverService > forwards a string payload (e.g. a URL) unchanged

Stack Traces | 0.658s run time

AssertionError: expected "vi.fn()" to be called with arguments: [ Array(3) ]

Number of calls: 0

 ❯ .../user/file/file-saver.service.spec.ts:54:20
 ❯ src/test-zone-setup.ts:90:33
 ❯ _ZoneDelegate.invoke node_modules/zone.js/fesm2015/zone.js:398:28
 ❯ ProxyZoneSpec.onInvoke node_modules/zone.js/fesm2015/zone-testing.js:2132:39
 ❯ _ZoneDelegate.invoke node_modules/zone.js/fesm2015/zone.js:397:34
 ❯ ZoneImpl.run node_modules/zone.js/fesm2015/zone.js:113:43
 ❯ src/test-zone-setup.ts:88:16

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

…uite

Copilot

Pull request overview

This PR adds Vitest unit coverage for the frontend FileSaverService (a thin wrapper around file-saver), improving confidence that the service correctly delegates payloads and optional arguments.

Changes:

Adds file-saver.service.spec.ts to verify delegation to file-saver’s saveAs for Blob and string inputs.
Adds assertions for pass-through behavior when filename and options are omitted.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…xera into test/file-saver-service-spec

aglinxinyuan · 2026-07-23T05:23:41Z

please fix the ci

github-actions · 2026-08-24T01:34:32Z

This pull request has been automatically marked as stale because it has
not had any activity for 30 days. It will be closed in 7 days if no
further activity occurs.

If this PR is still relevant, please:

Push new commits or rebase onto the latest main, or
Comment with a status update, or
Address any open review feedback.

To exempt this PR from auto-close, a maintainer can add the pinned label.
Thank you for your contribution to Apache Texera (incubating)!

github-actions · 2026-09-07T01:32:43Z

This pull request has been automatically closed due to 37 days of inactivity.
If you would like to continue this work, please re-open the PR or open a new
one referencing this. Thank you for your contribution.

Ma77Ball · 2026-10-20T07:26:00Z

Reopening: this was auto-closed by the stale bot after 37 days of inactivity, not because it was resolved or superseded. The change is still relevant and its tracking issue #6448 remains open. I'd like to continue it and will rebase it onto current main.

Ma77Ball · 2026-10-20T08:09:53Z

Reopening: auto-closed by the stale bot for inactivity, not resolved or superseded. The branch is now merged up to current main, and its tracking issue #6448 is still open.

Ma77Ball · 2026-10-20T08:19:31Z

This was auto-closed by the stale bot for inactivity, not because it was resolved. Continued in #9045 (same change, merged up to current main). Tracking issue #6448 is still open.

### What changes were proposed in this PR? - Adds a Vitest spec for `FileSaverService`, the thin wrapper whose `saveAs(data, filename?, options?)` forwards straight to the `file-saver` library's `saveAs`. - Mocks the `file-saver` library so the suite can assert the call is forwarded unchanged: a Blob payload passes through with its filename and options, and a string payload (such as a URL) passes through. - Asserts that an omitted filename and options arrive as `undefined`, and that an error thrown by the underlying `saveAs` propagates to the caller instead of being swallowed. ### Any related issues, documentation, discussions? Closes: apache#6448 Supersedes apache#6460, which the stale bot auto-closed for inactivity. The branch is now merged up to current `main`. ### How was this PR tested? - Run `cd frontend && npx ng test --include="**/file-saver.service.spec.ts" --watch=false`, expect the FileSaverService suite to pass. - Confirm the forwarding cases hold: a Blob and a string payload each reach the mocked `saveAs` unchanged, an omitted filename and options arrive as `undefined`, and a thrown error surfaces to the caller. ### Was this PR authored or co-authored using generative AI tooling? Co-authored with Claude Opus 4.8 in compliance with ASF --------- Signed-off-by: Xinyuan Lin <xinyual3@uci.edu> Co-authored-by: Xinyuan Lin <xinyual3@uci.edu> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

test(frontend): add unit tests for FileSaverService

592a5fc

github-actions Bot assigned Ma77Ball Jul 16, 2026

github-actions Bot added the frontend Changes related to the frontend GUI label Jul 16, 2026

test(frontend): mock file-saver module so the spy survives the full s…

4dbf738

…uite

aglinxinyuan requested a review from Copilot July 17, 2026 06:43

Copilot started reviewing on behalf of aglinxinyuan July 17, 2026 06:45

View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Comment thread frontend/src/app/dashboard/service/user/file/file-saver.service.spec.ts

Potential fix for pull request finding

8bd6576

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>

aglinxinyuan enabled auto-merge July 22, 2026 01:25

Ma77Ball and others added 3 commits July 21, 2026 19:39

test: address review comments

036aed3

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Merge branch 'main' into test/file-saver-service-spec

484d4c0

Merge branch 'test/file-saver-service-spec' of github.com:Ma77Ball/te…

c2c81f2

…xera into test/file-saver-service-spec

auto-merge was automatically disabled July 22, 2026 03:04
Head branch was pushed to by a user without write access

Ma77Ball and others added 2 commits July 21, 2026 20:12

Merge branch 'main' into test/file-saver-service-spec

6d4648b

Merge branch 'main' into test/file-saver-service-spec

05f183e

github-actions Bot added the stale label Aug 24, 2026

Yicong-Huang mentioned this pull request Sep 3, 2026

ci: block the merge until each release/* label has its manager's approval #8096

Merged

github-actions Bot closed this Sep 7, 2026

Ma77Ball mentioned this pull request Oct 20, 2026

test(frontend): add unit tests for FileSaverService #9045

Merged

Navigation Menu

Repository navigation

test(frontend): add unit tests for FileSaverService - #6460

test(frontend): add unit tests for FileSaverService#6460
Ma77Ball wants to merge 8 commits into
apache:mainfrom
Ma77Ball:test/file-saver-service-spec

Ma77Ball commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

codecov-commenter commented Jul 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

aglinxinyuan commented Jul 23, 2026

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

github-actions Bot commented Sep 7, 2026

Uh oh!

Ma77Ball commented Oct 20, 2026

Uh oh!

Ma77Ball commented Oct 20, 2026

Uh oh!

Ma77Ball commented Oct 20, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Ma77Ball commented Jul 16, 2026

What changes were proposed in this PR?

Any related issues, documentation, discussions?

How was this PR tested?

Was this PR authored or co-authored using generative AI tooling?

Uh oh!

github-actions Bot commented Jul 16, 2026

Automated Reviewer Suggestions

Uh oh!

codecov-commenter commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 5 Tests Failed:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

aglinxinyuan commented Jul 23, 2026

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

github-actions Bot commented Sep 7, 2026

Uh oh!

Ma77Ball commented Oct 20, 2026

Uh oh!

Ma77Ball commented Oct 20, 2026

Uh oh!

Ma77Ball commented Oct 20, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Jul 16, 2026 •

edited

Loading