Repository navigation
fix(licensing, v1.3): restore the ScalaPB notice on the vendored scalapb.proto - #8867
Conversation
…oto (#8806) ### What changes were proposed in this PR? Per the note at the end of #8802, `common/workflow-core/src/main/protobuf/scalapb/scalapb.proto` is vendored from ScalaPB (Apache-2.0) but carried the standard ASF header — the same class of problem as #8775. Mirroring that fix: - `scalapb.proto`: ASF header → a vendored-from notice (upstream ships the file with no header; its license is the repository-level Apache-2.0, so no separate license copy is needed); - root `LICENSE`: a ScalaPB entry next to the other Apache-2.0 third-party entries ("this LICENSE file"); - `.licenserc.yaml`: exempt the file from the ASF-header check. Comment-only change to the proto; protoc output is unaffected. This addresses only the vendored-file item in #8802 — the build-time-generation proposal stays open there. ### Any related issues, documentation, discussions? Addresses the vendored scalapb.proto item in #8802. Same pattern as #8775/#8776. ### How was this PR tested? License-metadata-only change; the Check License Headers CI job verifies the exemption. The file is identical on main and both release branches. ### Was this PR authored or co-authored using generative AI tooling? (backported from commit 1df2c56) Generated-by: Claude Code (claude-fable-5)
|
Clean cherry-pick — nothing here was edited by hand. It applied to Close this PR and reopen it to start its required checks. This pull request was opened by After that: approve, and enable auto-merge if you would rather not come back when the checks finish. |
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v1.3 #8867 +/- ##
===============================================
Coverage 94.09% 94.10%
- Complexity 4809 4810 +1
===============================================
Files 1194 1194
Lines 48625 48625
Branches 5864 5864
===============================================
+ Hits 45755 45757 +2
+ Misses 1414 1413 -1
+ Partials 1456 1455 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 657 | 0.401 | 14,524/18,886/18,886 us | 🟢 -16.5% / 🔴 +40.1% |
| ⚪ | bs=100 sw=10 sl=64 | 1,506 | 0.919 | 62,784/96,001/96,001 us | ⚪ within ±5% / 🟢 -28.6% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,866 | 1.139 | 534,837/596,146/596,146 us | ⚪ within ±5% / 🟢 +46.7% |
Baseline details
Latest main 33b47a8 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 657 tuples/sec | 654 tuples/sec | 962.17 tuples/sec | +0.5% | -31.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.401 MB/s | 0.399 MB/s | 0.587 MB/s | +0.5% | -31.7% |
| bs=10 sw=10 sl=64 | p50 | 14,524 us | 13,564 us | 11,046 us | +7.1% | +31.5% |
| bs=10 sw=10 sl=64 | p95 | 18,886 us | 22,605 us | 13,484 us | -16.5% | +40.1% |
| bs=10 sw=10 sl=64 | p99 | 18,886 us | 22,605 us | 16,626 us | -16.5% | +13.6% |
| bs=100 sw=10 sl=64 | throughput | 1,506 tuples/sec | 1,530 tuples/sec | 1,234 tuples/sec | -1.6% | +22.0% |
| bs=100 sw=10 sl=64 | MB/s | 0.919 MB/s | 0.934 MB/s | 0.753 MB/s | -1.6% | +22.0% |
| bs=100 sw=10 sl=64 | p50 | 62,784 us | 60,649 us | 87,952 us | +3.5% | -28.6% |
| bs=100 sw=10 sl=64 | p95 | 96,001 us | 99,521 us | 93,929 us | -3.5% | +2.2% |
| bs=100 sw=10 sl=64 | p99 | 96,001 us | 99,521 us | 103,096 us | -3.5% | -6.9% |
| bs=1000 sw=10 sl=64 | throughput | 1,866 tuples/sec | 1,901 tuples/sec | 1,272 tuples/sec | -1.8% | +46.7% |
| bs=1000 sw=10 sl=64 | MB/s | 1.139 MB/s | 1.161 MB/s | 0.777 MB/s | -1.9% | +46.7% |
| bs=1000 sw=10 sl=64 | p50 | 534,837 us | 521,383 us | 862,437 us | +2.6% | -38.0% |
| bs=1000 sw=10 sl=64 | p95 | 596,146 us | 622,995 us | 904,996 us | -4.3% | -34.1% |
| bs=1000 sw=10 sl=64 | p99 | 596,146 us | 622,995 us | 929,784 us | -4.3% | -35.9% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,304.45,200,128000,657,0.401,14523.56,18885.71,18885.71
1,100,10,64,20,1327.79,2000,1280000,1506,0.919,62783.97,96001.07,96001.07
2,1000,10,64,20,10720.41,20000,12800000,1866,1.139,534837.37,596145.58,596145.58
What changes were proposed in this PR?
Automated backport of #8806 to
release/v1.3.Source: 1df2c56 · automation run
Any related issues, documentation, discussions?
Backport of #8806.
How was this PR tested?
The backported tree built green before #8806 merged. Release-branch CI runs on this PR once it is reopened — see the comment below.
Was this PR authored or co-authored using generative AI tooling?
No.