Skip to content

feat(frontend): open the result panel at its full height inside the window - #9056

Merged
aglinxinyuan merged 2 commits into
apache:mainfrom
kz930:feat/9055-dock-result-panel
Oct 28, 2026
Merged

feat(frontend): open the result panel at its full height inside the window#9056
aglinxinyuan merged 2 commits into
apache:mainfrom
kz930:feat/9055-dock-result-panel

Conversation

@kz930

@kz930 kz930 commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

The result panel's default height went from 300 to 500, but its stylesheet still placed it 300px above the bottom of the workspace, so a panel opened or docked at the default height left its bottom 200px below the window, usually the pager with them. The panel's offset now comes from the same constant as its default height, so the two cannot drift apart again.

Before After
result-panel-docked-below-window result-panel-docked-after-fix

Any related issues, documentation, discussions?

Closes #9055. Part of #9052.

How was this PR tested?

A new case in ResultPanelComponent's spec checks that the panel is placed one default height above the workspace's bottom edge. It fails on main. In the running app, the docked panel now ends at the window's bottom edge, where on main it ran 200px past it.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

🤖 Generated with Claude Code

@kz930 @claude
fix(frontend): dock the result panel at its default height
d35d3a2 
The default height went from 300 to 500 while the docked offset stayed at
-300px, so a panel that had never been moved, and every press of the dock
button, left 200px of it below the window. The offset now comes from the
same constant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 20, 2026
Open
Draft
@kz930

kz930 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

@carloea2 could you take a look at this when you have a chance? Thanks!

carloea2
carloea2 approved these changes Oct 20, 2026
View reviewed changes

@carloea2 carloea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

61 ResultPanelComponent tests and focused formatting checks pass locally on current main. The offset now matches the default height. Please use fix(frontend) for the title, since this restores the previously working docked position.

@kz930 kz930 changed the title feat(frontend): open the result panel at its full height inside the window fix(frontend): open the result panel at its full height inside the window Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @yangzhang75, @xuang7, @aglinxinyuan
    You can notify them by mentioning @yangzhang75, @xuang7, @aglinxinyuan in a comment.

@github-actions github-actions Bot added feature frontend Changes related to the frontend GUI labels Oct 20, 2026
@Yicong-Huang Yicong-Huang added release/v1.3 back porting to release/v1.3 release/v1.2 back porting to release/v1.2 labels Oct 21, 2026
@github-actions
github-actions Bot requested review from mengw15 and xuang7 October 21, 2026 00:40
@github-actions

github-actions Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Backport auto-label report

This fix: PR was checked against each actively-supported release branch. A release/* label nominates a backport target; the branch's release manager approving this PR is what sends the fix there. The required Backport Approvals check stays red until every label below is approved, so each manager either approves or removes their own label — which is why the labels left on a merged PR are exactly the branches it reached.

Release branch Analysis
✅ release/v1.3 Change detected on this branch — label added; this fix is queued to backport here. @mengw15 decides: approving sends the fix here, removing this label declines it. The merge waits on one or the other. Review requested.
✅ release/v1.2 Change detected on this branch — label added; this fix is queued to backport here. @xuang7 decides: approving sends the fix here, removing this label declines it. The merge waits on one or the other. Review requested.

Auto-label run.

@codecov-commenter

codecov-commenter commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (22b82a2) to head (d35d3a2).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #9056      +/-   ##
============================================
+ Coverage     92.33%   93.17%   +0.83%     
  Complexity     5045     5045              
============================================
  Files          1261     1274      +13     
  Lines         54120    62992    +8872     
  Branches       6768     8960    +2192     
============================================
+ Hits          49974    58690    +8716     
- Misses         2486     2547      +61     
- Partials       1660     1755      +95
Flag Coverage Δ *Carryforward flag
access-control-service 77.38% <ø> (ø) Carriedforward from 22b82a2
agent-service 99.16% <ø> (ø) Carriedforward from 22b82a2
amber 87.31% <ø> (ø) Carriedforward from 22b82a2
computing-unit-managing-service 60.48% <ø> (ø) Carriedforward from 22b82a2
config-service 87.37% <ø> (ø) Carriedforward from 22b82a2
file-service 82.00% <ø> (ø) Carriedforward from 22b82a2
frontend 96.99% <100.00%> (+0.42%) ⬆️
notebook-migration-service 83.73% <ø> (ø) Carriedforward from 22b82a2
pyamber 98.57% <ø> (ø) Carriedforward from 22b82a2
workflow-compiling-service 72.43% <ø> (ø) Carriedforward from 22b82a2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kz930 kz930 changed the title fix(frontend): open the result panel at its full height inside the window feat(frontend): open the result panel at its full height inside the window Oct 26, 2026
@aglinxinyuan
aglinxinyuan disabled auto-merge October 27, 2026 21:48
@aglinxinyuan aglinxinyuan removed release/v1.2 back porting to release/v1.2 release/v1.3 back porting to release/v1.3 labels Oct 27, 2026
@aglinxinyuan
aglinxinyuan added this pull request to the merge queue Oct 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 27, 2026
@aglinxinyuan
aglinxinyuan added this pull request to the merge queue Oct 28, 2026
Merged via the queue into apache:main with commit 569f721 Oct 28, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aglinxinyuan aglinxinyuan aglinxinyuan approved these changes
+1 more reviewer
@carloea2 carloea2 carloea2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kz930 kz930

Labels

feature frontend Changes related to the frontend GUI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Open the result panel at its full height inside the window

5 participants

@kz930 @codecov-commenter @aglinxinyuan @carloea2 @Yicong-Huang