Repository navigation
fix(ci, v1.3): raise merge queue timeout - #9161
Merged
aglinxinyuan merged 1 commit intoOct 26, 2026
Merged
aglinxinyuan merged 1 commit into
aglinxinyuan merged 1 commit into
Conversation
### What changes were proposed in this PR? If this limit is too low, the merge queue can enter a starvation loop where every job times out if runners are simply busy. Raising the limit stops this. ### Any related issues, documentation, discussions? Closes apache#9095 and https://issues.apache.org/jira/browse/INFRA-28569 ### How was this PR tested? It wasn't; it's specific to ASF infra. I got the idea from a helpful hint from Andrew Lamb of DataFusion. ### Was this PR authored or co-authored using generative AI tooling? No (cherry picked from commit 2407d79)
Contributor
Automated Reviewer SuggestionsBased on the
|
mengw15
approved these changes
Oct 26, 2026
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 419 | 0.256 | 22,833/33,689/33,689 us | 🔴 +7.6% / 🔴 +175.6% |
| 🟢 | bs=100 sw=10 sl=64 | 956 | 0.583 | 103,950/120,547/120,547 us | 🟢 -25.6% / 🔴 +38.3% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,132 | 0.691 | 884,215/997,712/997,712 us | ⚪ within ±5% / 🔴 +22.0% |
Baseline details
Latest main 10827b7 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 419 tuples/sec | 451 tuples/sec | 1,019 tuples/sec | -7.1% | -58.9% |
| bs=10 sw=10 sl=64 | MB/s | 0.256 MB/s | 0.275 MB/s | 0.622 MB/s | -6.9% | -58.8% |
| bs=10 sw=10 sl=64 | p50 | 22,833 us | 22,342 us | 10,144 us | +2.2% | +125.1% |
| bs=10 sw=10 sl=64 | p95 | 33,689 us | 31,320 us | 12,225 us | +7.6% | +175.6% |
| bs=10 sw=10 sl=64 | p99 | 33,689 us | 31,320 us | 15,527 us | +7.6% | +117.0% |
| bs=100 sw=10 sl=64 | throughput | 956 tuples/sec | 937 tuples/sec | 1,371 tuples/sec | +2.0% | -30.3% |
| bs=100 sw=10 sl=64 | MB/s | 0.583 MB/s | 0.572 MB/s | 0.837 MB/s | +1.9% | -30.3% |
| bs=100 sw=10 sl=64 | p50 | 103,950 us | 102,292 us | 79,910 us | +1.6% | +30.1% |
| bs=100 sw=10 sl=64 | p95 | 120,547 us | 162,097 us | 87,155 us | -25.6% | +38.3% |
| bs=100 sw=10 sl=64 | p99 | 120,547 us | 162,097 us | 106,643 us | -25.6% | +13.0% |
| bs=1000 sw=10 sl=64 | throughput | 1,132 tuples/sec | 1,132 tuples/sec | 1,415 tuples/sec | 0.0% | -20.0% |
| bs=1000 sw=10 sl=64 | MB/s | 0.691 MB/s | 0.691 MB/s | 0.864 MB/s | 0.0% | -20.0% |
| bs=1000 sw=10 sl=64 | p50 | 884,215 us | 881,204 us | 780,407 us | +0.3% | +13.3% |
| bs=1000 sw=10 sl=64 | p95 | 997,712 us | 970,029 us | 817,814 us | +2.9% | +22.0% |
| bs=1000 sw=10 sl=64 | p99 | 997,712 us | 970,029 us | 848,683 us | +2.9% | +17.6% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,477.45,200,128000,419,0.256,22833.01,33688.75,33688.75
1,100,10,64,20,2092.93,2000,1280000,956,0.583,103949.65,120547.24,120547.24
2,1000,10,64,20,17673.32,20000,12800000,1132,0.691,884214.87,997711.55,997711.55
aglinxinyuan
enabled auto-merge
October 26, 2026 22:18
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v1.3 #9161 +/- ##
===============================================
Coverage 94.10% 94.10%
- Complexity 4809 4810 +1
===============================================
Files 1194 1194
Lines 48625 48625
Branches 5864 5864
===============================================
Hits 45760 45760
Misses 1411 1411
Partials 1454 1454
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
via the queue into
apache:release/v1.3
with commit Oct 26, 2026
148b0c2
42 of 48 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Backport of #9096 to
release/v1.3. It raises the merge queue'scheck_response_timeout_minutesin.asf.yamlfrom 45 to 360, sorelease/v1.3's copy matchesmain.#9100 was also meant to come along, but it is already on
release/v1.3as #9132, with the same patch-id. So this PR carries only #9096. #9096 never got arelease/v1.3label because the backport auto-labeler skipsfix(ci)PRs.No live setting changes. ASF applies the
github:block of.asf.yamlonly from the default branch (asfyaml/feature/github/__init__.pyreturns early for any other branch).main's Merge Queue ruleset, which already listsrefs/heads/release/v1.3, has used 360 since #9096. This backport only stops the release branch's copy from showing a stale 45.Only that one line changes. The other differences between the two copies are left as they are: the include list here has no
release/v1.3, and theBackport Approvalsruleset is missing.Any related issues, documentation, discussions?
Backport of #9096. Related: #9095, INFRA-28569.
How was this PR tested?
git cherry-pick -x 2407d79ee7applies cleanly ontorelease/v1.3. The diff is the singlecheck_response_timeout_minutesline. The file still parses, and the Merge Queue rule reads 360:Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)