Repository navigation
refactor(workflow-core): drop dead fromString and import - #9181
Merged
aglinxinyuan merged 2 commits intoOct 27, 2026
Merged
aglinxinyuan merged 2 commits into
aglinxinyuan merged 2 commits into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9181 +/- ##
============================================
- Coverage 91.98% 91.98% -0.01%
+ Complexity 5085 5083 -2
============================================
Files 1281 1281
Lines 55812 55811 -1
Branches 7076 7076
============================================
- Hits 51338 51335 -3
Misses 2734 2734
- Partials 1740 1742 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 385 | 0.235 | 25,375/32,589/32,589 us | 🔴 +12.4% / 🔴 +136.6% |
| 🔴 | bs=100 sw=10 sl=64 | 808 | 0.493 | 119,681/164,737/164,737 us | 🔴 +17.5% / 🔴 +76.9% |
| 🔴 | bs=1000 sw=10 sl=64 | 954 | 0.582 | 1,034,041/1,186,156/1,186,156 us | 🔴 +5.7% / 🔴 +34.6% |
Baseline details
Latest main 6659eec from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 385 tuples/sec | 434 tuples/sec | 941.58 tuples/sec | -11.3% | -59.1% |
| bs=10 sw=10 sl=64 | MB/s | 0.235 MB/s | 0.265 MB/s | 0.575 MB/s | -11.3% | -59.1% |
| bs=10 sw=10 sl=64 | p50 | 25,375 us | 22,568 us | 10,991 us | +12.4% | +130.9% |
| bs=10 sw=10 sl=64 | p95 | 32,589 us | 34,438 us | 13,776 us | -5.4% | +136.6% |
| bs=10 sw=10 sl=64 | p99 | 32,589 us | 34,438 us | 16,872 us | -5.4% | +93.2% |
| bs=100 sw=10 sl=64 | throughput | 808 tuples/sec | 860 tuples/sec | 1,264 tuples/sec | -6.0% | -36.1% |
| bs=100 sw=10 sl=64 | MB/s | 0.493 MB/s | 0.525 MB/s | 0.772 MB/s | -6.1% | -36.1% |
| bs=100 sw=10 sl=64 | p50 | 119,681 us | 114,770 us | 86,073 us | +4.3% | +39.0% |
| bs=100 sw=10 sl=64 | p95 | 164,737 us | 140,155 us | 93,135 us | +17.5% | +76.9% |
| bs=100 sw=10 sl=64 | p99 | 164,737 us | 140,155 us | 111,124 us | +17.5% | +48.2% |
| bs=1000 sw=10 sl=64 | throughput | 954 tuples/sec | 968 tuples/sec | 1,304 tuples/sec | -1.4% | -26.9% |
| bs=1000 sw=10 sl=64 | MB/s | 0.582 MB/s | 0.591 MB/s | 0.796 MB/s | -1.5% | -26.9% |
| bs=1000 sw=10 sl=64 | p50 | 1,034,041 us | 1,031,658 us | 841,986 us | +0.2% | +22.8% |
| bs=1000 sw=10 sl=64 | p95 | 1,186,156 us | 1,122,721 us | 881,107 us | +5.7% | +34.6% |
| bs=1000 sw=10 sl=64 | p99 | 1,186,156 us | 1,122,721 us | 918,208 us | +5.7% | +29.2% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,518.89,200,128000,385,0.235,25375.16,32589.02,32589.02
1,100,10,64,20,2474.22,2000,1280000,808,0.493,119680.52,164737.06,164737.06
2,1000,10,64,20,20962.93,20000,12800000,954,0.582,1034040.85,1186155.77,1186155.77
kunwp1
approved these changes
Oct 27, 2026
kunwp1
enabled auto-merge
October 27, 2026 21:14
aglinxinyuan
disabled auto-merge
October 27, 2026 22:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Removes unused Java members in
common/workflow-core:ExecutionMode.fromString(ExecutionMode.java:26): Redundant wrapperpublic static ExecutionMode fromString(String value) { return valueOf(value); }with 0 callers across the repository (all callers use standardExecutionMode.valueOfor direct enum constants).LargeBinary.java:25: Unused importimport org.apache.texera.amber.core.executor.OperatorExecutor;with 0 references in the file.+0/-3 lines. Pure deletion with no behaviour change.
Any related issues, documentation, discussions?
Closes #9180.
How was this PR tested?
javac ExecutionMode.javagit grep -nw "ExecutionMode.fromString"(1 hit, now 0)git grep -nw "OperatorExecutor"inLargeBinary.java(1 hit, now 0)Was this PR authored or co-authored using generative AI tooling?
Generated-by: Antigravity (Claude Opus 5.5)