Skip to content

refactor(frontend): drop dead members across agent ui - #9199

Open
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:refactor/agent-ui-dead-members
Open

aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:refactor/agent-ui-dead-members

Conversation

@aglinxinyuan

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Removes dead properties, unused event handlers, and dead stylesheet rules across Agent UI components:

  1. agent-registration.component.ts:
    • Drops write-only hasLoadingError property (only assigned, never read in template or by callers).
  2. agent-panel.component.ts:
    • Drops write-only isDocked property and uncalled handleDragStart() method.
  3. agent-panel.component.html:
    • Drops (cdkDragStarted)="handleDragStart()" binding.
  4. agent-interaction.component.scss:
    • Drops dead &.compact stylesheet rule with zero references in templates or components.
  5. Unit test updates:
    • Adjusts agent-registration.component.spec.ts and agent-panel.component.spec.ts to remove assertions on the dropped internal properties.

+0/-37 lines. Pure refactoring with no behavior change.

Any related issues, documentation, discussions?

Closes #9196.

How was this PR tested?

  • Prettier check passed:
    npx prettier --check src/app/workspace/component/agent/agent-panel/agent-registration/agent-registration.component.ts src/app/workspace/component/agent/agent-panel/agent-registration/agent-registration.component.spec.ts src/app/workspace/component/agent/agent-interaction/agent-interaction.component.scss src/app/workspace/component/agent/agent-panel/agent-panel.component.html src/app/workspace/component/agent/agent-panel/agent-panel.component.ts src/app/workspace/component/agent/agent-panel/agent-panel.component.spec.ts
  • TypeScript compilation check (src/tsconfig.spec.json): zero errors in modified files.
  • Verified 0 callers repo-wide for isDocked and hasLoadingError.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Antigravity (Claude Opus 5.5)

@aglinxinyuan aglinxinyuan added refactor Refactor the code frontend Changes related to the frontend GUI labels Oct 27, 2026
Copilot AI balanced review requested due to automatic review settings October 27, 2026 23:21
@aglinxinyuan aglinxinyuan self-assigned this Oct 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @bobbai00, @Yicong-Huang
    You can notify them by mentioning @bobbai00, @Yicong-Huang in a comment.

@aglinxinyuan
aglinxinyuan requested review from bobbai00, kunwp1 and mengw15 and removed request for bobbai00 and mengw15 October 27, 2026 23:26
@kunwp1
kunwp1 requested a lite review from Copilot October 28, 2026 23:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI refactor Refactor the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up dead methods, write-only properties, and styles across Agent UI components

2 participants