[CI] Enable Windows ARM64 wheels - #691
Open
vortex-captain wants to merge 8 commits into
Open
Conversation
…sion - Fix Python library path detection in _build_optional_torch_c_dlpack.py to also check for versioned Python library (e.g. python312.lib) in addition to the major-only name (python3.lib). Some Python distributions like nuget-cpython (used by cibuildwheel on Windows) only provide the versioned library. When only the versioned library is found, explicitly add it to linker flags so pybind11's #pragma comment directive can resolve correctly. - Fix test_optional_torch_c_dlpack.py to use platform-appropriate library extension: .dll on Windows, .so elsewhere. Previously hardcoded .so caused test failures on Windows even when build succeeded.
…ilure Fix Windows wheel build: versioned Python lib detection and .dll extension
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Member
|
good to understand usecases, likely we will align with pytorch on availability of win arm64 wheel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
A local private PyTorch 2.14 Windows ARM64 wheel was also tested with the released tvm-ffi 0.1.12 ARM64 wheel. The suite reported 2300 passed, 17 skipped, and 4 xfailed. Only these two optional addon-build tests failed:
test_build_torch_c_dlpack_extensiontest_parallel_buildThose failures are due to tvm-ffi 0.1.12 compiling the addon as C++17 while the PyTorch 2.14 headers require C++20. Current main already selects C++20 for PyTorch 2.13 and newer.
Future steps
win_arm64.