Reject appended plaintext listener parameters#1517
Open
M0nd0R wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change rejects plaintext request-listener parameters that are appended to an otherwise encrypted bookmarkable page URL.
Root Cause
decryptEntireUrl(...)decrypted the protected URL and then merged additional query parameters from the incoming request. A plaintextPageComponentInfoparameter could therefore survive outside the encrypted payload and still affect request mapping.Fix
Reject incoming query parameters that parse as
PageComponentInfobefore merging the request query parameters back into the decrypted URL.Validation
mvn -pl wicket-core-tests -am -Dtest=org.apache.wicket.core.request.mapper.CryptoMapperTest -Dsurefire.failIfNoSpecifiedTests=false clean test