Skip to content

WICKET-6941 Add visible attribute to AbstractColumn to hide/show columns in DataTable/DataGridView #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RLStokes wants to merge 20 commits into
base: wicket-9.x
Choose a base branch
from
Open

WICKET-6941 Add visible attribute to AbstractColumn to hide/show columns in DataTable/DataGridView #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4dd4735
WICKET-6941 Add visible attribute to AbstractColumn to hide/show colu…
RLStokes Dec 30, 2021
3cb347a
WICKET-6941 Add visible attribute to AbstractColumn review comments.
RLStokes Jan 1, 2022
84bd802
Merge branch 'apache:wicket-9.x' into wicket-9.x
RLStokes Feb 21, 2022
4ec8493
Version update
RLStokes Feb 28, 2022
d8e4f3d
Merge branch 'wicket-9.x' of github.com:RLStokes/wicket into wicket-9.x
RLStokes Feb 28, 2022
829ecb3
Merge branch 'apache:wicket-9.x' into wicket-9.x
RLStokes Dec 20, 2022
8507303
Merge branch 'wicket-9.x' of github.com:RLStokes/wicket into wicket-9.x
RLStokes Dec 20, 2022
549b74e
Merge branch 'apache:wicket-9.x' into wicket-9.x
RLStokes Aug 25, 2023
062dd74
Merge branch 'apache:wicket-9.x' into wicket-9.x
RLStokes Sep 5, 2023
45ed67e
Merge branch 'apache:wicket-9.x' into wicket-9.x
RLStokes Nov 16, 2023
0b98ad3
Merge branch 'apache:wicket-9.x' into wicket-9.x
RLStokes Dec 4, 2023
02ebc6d
Merge branch 'apache:wicket-9.x' into wicket-9.x
RLStokes Jan 22, 2024
72304fc
Merge branch 'apache:wicket-9.x' into wicket-9.x
RLStokes Feb 13, 2024
73ef3af
Merge branch 'apache:wicket-9.x' into wicket-9.x
RLStokes Apr 16, 2024
c9a1656
Merge branch 'apache:wicket-9.x' into wicket-9.x
RLStokes Jul 16, 2024
2e2a59a
Version Update
RLStokes Jul 23, 2024
18e2fb0
Merge branch 'apache:wicket-9.x' into wicket-9.x
RLStokes Dec 16, 2025
4a5fbd7
Merge branch 'wicket-9.x' of github.com:RLStokes/wicket into wicket-9.x
RLStokes Jul 14, 2026
a6cef28
Version Update.
RLStokes Jul 14, 2026
80bfa8a
Merge Conflicts.
RLStokes Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion archetypes/quickstart/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-parent</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../../pom.xml</relativePath>
</parent>
<artifactId>wicket-archetype-quickstart</artifactId>
Expand Down
49 changes: 32 additions & 17 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</parent>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-parent</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<packaging>pom</packaging>
<name>Wicket Parent</name>
<description>Wicket is a Java-based open source component web application framework.</description>
Expand Down Expand Up @@ -94,6 +94,21 @@
<url>http://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git</url>
<tag>HEAD</tag>
</scm>
<distributionManagement>
<repository>
<id>fileserver</id>
<name>fileserver.kennedymensclub.com</name>
<url>scpexe://fileserver.kennedymensclub.com/home/robstokes/repo</url>
</repository>
<site>
<id>kennedymensclub.com</id>
<url>file:${project.build.directory}\site</url>
</site>
<snapshotRepository>
<id>filesystem</id>
<url>file://C:/javastuff/localrepo/snapshots</url>
</snapshotRepository>
</distributionManagement>
<modules>
<!-- wicket-eclipse-settings is separate released -->
<module>wicket</module>
Expand Down Expand Up @@ -339,37 +354,37 @@
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>pom</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-auth-roles</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-bean-validation</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-cdi</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-core</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-devutils</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
Expand All @@ -380,61 +395,61 @@
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-extensions</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-guice</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-ioc</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-jmx</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-native-websocket-core</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-native-websocket-javax</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-request</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-spring</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-util</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-velocity</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<type>jar</type>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion testing/wicket-common-tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-parent</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../../pom.xml</relativePath>
</parent>
<artifactId>wicket-common-tests</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion testing/wicket-js-tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-parent</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../../pom.xml</relativePath>
</parent>
<artifactId>wicket-js-tests</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion wicket-auth-roles/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-parent</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-auth-roles</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion wicket-bean-validation/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-parent</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-bean-validation</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion wicket-cdi/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-parent</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-cdi</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion wicket-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-parent</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-core</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion wicket-core/src/test/java/org/apache/wicket/page/PageAccessSynchronizerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ void failToReleaseUnderLoad() throws Exception
// set the synchronizer timeout one second longer than the test runs to prevent
// starvation to become an issue
final PageAccessSynchronizer sync = new PageAccessSynchronizer(
duration.plus(Duration.ofSeconds(1)));
duration.plus(Duration.ofSeconds(5)));

final CountDownLatch latch = new CountDownLatch(100);
for (int count = 0; count < 100; count++)
Expand Down
2 changes: 1 addition & 1 deletion wicket-devutils/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-parent</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-devutils</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion wicket-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-parent</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-examples</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion wicket-experimental/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-parent</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../pom.xml</relativePath>
</parent>
<groupId>org.apache.wicket.experimental.wicket9</groupId>
Expand Down
2 changes: 1 addition & 1 deletion wicket-experimental/wicket-http2/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket.experimental.wicket9</groupId>
<artifactId>wicket-experimental</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-http2</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion wicket-experimental/wicket-metrics/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket.experimental.wicket9</groupId>
<artifactId>wicket-experimental</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-metrics</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion wicket-extensions/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-parent</artifactId>
<version>9.22.0-SNAPSHOT</version>
<version>9.22.0-KMC</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-extensions</artifactId>
Expand Down
28 changes: 15 additions & 13 deletions ...ava/org/apache/wicket/extensions/markup/html/repeater/data/grid/AbstractDataGridView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,21 +149,23 @@ protected final void populateItem(final Item<T> item)
for (int i = 0; i < populatorsNumber; i++)
{
ICellPopulator<T> populator = populators.get(i);
IModel<ICellPopulator<T>> populatorModel = new Model<>(populator);
Item<ICellPopulator<T>> cellItem = newCellItem(cells.newChildId(), i, populatorModel);
cells.add(cellItem);

populator.populateItem(cellItem, CELL_ITEM_ID, item.getModel());

if (cellItem.get("cell") == null)
if (populator.isVisible())
{
throw new WicketRuntimeException(
populator.getClass().getName() +
".populateItem() failed to add a component with id [" +
CELL_ITEM_ID +
"] to the provided [cellItem] object. Make sure you call add() on cellItem and make sure you gave the added component passed in 'componentId' id. ( *cellItem*.add(new MyComponent(*componentId*, rowModel) )");
IModel<ICellPopulator<T>> populatorModel = new Model<>(populator);
Item<ICellPopulator<T>> cellItem = newCellItem(cells.newChildId(), i, populatorModel);
cells.add(cellItem);

populator.populateItem(cellItem, CELL_ITEM_ID, item.getModel());

if (cellItem.get("cell") == null)
{
throw new WicketRuntimeException(
populator.getClass().getName() +
".populateItem() failed to add a component with id [" +
CELL_ITEM_ID +
"] to the provided [cellItem] object. Make sure you call add() on cellItem and make sure you gave the added component passed in 'componentId' id. ( *cellItem*.add(new MyComponent(*componentId*, rowModel) )");
}
}
}

}
}
Loading