levels: return "invalid" for out-of-range Level.String() - #120
Open
vulragrag-star wants to merge 1 commit into
Open
vulragrag-star wants to merge 1 commit into
vulragrag-star wants to merge 1 commit into
Conversation
InvalidLevel is -1 and indexing levelNames panics. Guard the bounds and return "invalid" so String/MarshalJSON stay safe. Fixes apex#75.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Level.String()indexedlevelNameswithout bounds checks.InvalidLevelis-1, so callingString()(orMarshalJSON, which uses it) panicked. Return"invalid"for out-of-range levels instead.Fixes #75.
How I did it
Guard
l < DebugLevel || int(l) >= len(levelNames)before indexing. Matches the approach @tj already +1'd on the issue.How to verify it
Includes
TestLevel_String/TestLevel_MarshalJSON_InvalidcoveringInvalidLeveland an out-of-range value.