Repository navigation
Conversation
BrailleBlaster only offered Spanish as grade 1 (SPANISH-US). The new SPANISH-US-CONTRACTED profile uses liblouis's Spanish grade 2 table, es-g2.ctb, which is already bundled, for literary text and for text in math books. Uncontracted and computer braille stay grade 1, the same split the UEB profiles use. The Translation settings menu and the --braille-profile option both list the brailleSettings files, so the new file is all they need. SPANISH-US is unchanged and stays grade 1, so existing documents and scripts keep working. SpanishProfilesTest checks both profiles' tables, that grade 2 contracts "estado de cuenta" to "$d d cu5ta", and that --braille-profile SPANISH-US-CONTRACTED parses and finds its file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BrailleBlaster only offered Spanish as grade 1 (
SPANISH-US). Thisadds grade 2 as a new profile,
SPANISH-US-CONTRACTED.Changes
programData/utd/SPANISH-US-CONTRACTED.brailleSettings.xml.Literary text and text in math books use liblouis's Spanish grade 2
table,
es-g2.ctb, which is already bundled. Uncontracted andcomputer braille stay grade 1, the same split the UEB profiles use.
--braille-profileboth list the brailleSettings files, so the newprofile appears in both.
SPANISH-USis unchanged and stays grade 1.Usage:
Testing
SpanishProfilesTest: both profiles' tables, a real grade 2translation ("estado de cuenta" ->
$d d cu5ta), and--braille-profile SPANISH-US-CONTRACTEDparsing and finding itsfile.
output is byte-for-byte the same as before, and grade 2 output is
contracted.
mvnw packagewith tests passes.For review
The liblouis grade 2 table puts dot 5 (
") before some capitalisedEnglish words (
".BANK1,".BOX). That comes from the table itselfand should be checked by a Spanish braille reader.