Repository navigation
Keep the blank line before a list straight after a table - #182
Merged
Merged
Conversation
Since PR #181 a list after a table lost its blank line, so the footnote under the WC loan table ran straight on from the last row. Only clear the list's spacing when an empty spacer paragraph (ASM's LWS spacers) came between the table and the list. docx-page-break.lua drops blank paragraphs, so a new filter, docx-empty-paragraph.lua, runs first and keeps them as empty-paragraph markers; MarkTableSpacers records a marker after a table and removes them all before FixNestedList.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #181, a list straight after a table lost its blank line, so the footnote under the WC loan table ran straight on from the last row.
Fix
The list's spacing is now cleared only when an empty spacer paragraph (ASM's LWS spacers) came between the table and the list.
docx-page-break.luadrops blank paragraphs, so a new filter,docx-empty-paragraph.lua, runs first and keeps them as empty-paragraph markers.FixTableSpacing(MarkTableSpacers) records a marker after a table, then removes all the markers beforeFixNestedList.Tests
DocxTableSpacingTest: table then text, table / empty paragraph / text, and an empty paragraph away from a table.