fix(laravel): ignore invalid range filter values - #8632
Open
NotAFlightRisk wants to merge 3 commits into
Open
NotAFlightRisk wants to merge 3 commits into
NotAFlightRisk wants to merge 3 commits into
Conversation
soyuka
reviewed
Oct 5, 2026
| public function apply(Builder $builder, mixed $values, Parameter $parameter, array $context = []): Builder | ||
| { | ||
| if (!\is_array($values)) { | ||
| return $builder; |
Member
There was a problem hiding this comment.
can we add a log like we do in other filters so that a user can debug this ?
Contributor
Author
There was a problem hiding this comment.
Cheers @soyuka, done. I'd only compared it with the other Laravel filters, and none of those log, so I never looked at how the Doctrine range filter handles it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Laravel
RangeFilternow ignores values it can't use, rather than throwing a 500. On the workbench app/api/books?isbn_range=5was failing withforeach() argument must be of type array|object, string given, and?isbn_range[unknown]=5withUndefined array key "unknown".Theyre both pretty easy for a client to get wrong, eihter by leaving the operator off or misspelling it. Both come back 200 with the unfiltered list now.