feat: Add callback for server startup failure - #1192
Merged
Conversation
Author
|
Linking #1183 |
KazuCocoa
approved these changes
Jul 30, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 30, 2026
## [16.1.0](v16.0.3...v16.1.0) (2026-07-30) ### Features * Add callback for server startup failure ([#1192](#1192)) ([3a80439](3a80439))
|
🎉 This PR is included in version 16.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FBWebServer.startServing currently has no way to report a failure to bind the HTTP listener (e.g. every port in the configured binding range is already in use) other than calling abort(), killing the whole process with no structured error. This makes it impossible for any embedder/subclass to handle the failure gracefully (log it, retry, fail a test cleanly, etc.).
This adds an optional FBWebServerDelegate callback, webServer:didFailToStartWithError:, that is invoked with the underlying NSError when the HTTP server fails to start. If the delegate doesn't implement it, the existing abort() behavior is preserved, so this is fully backward compatible.
Changes