Skip to content

fix(android): send the gsmVoice and powerAc execute method names #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theluckystrike wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(android): send the gsmVoice and powerAc execute method names #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appium/webdriver/extensions/android/gsm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def set_gsm_voice(self, state: str) -> Self:
Returns:
Union['WebDriver', 'Gsm']: Self instance
"""
ext_name = 'mobile: gmsVoice'
ext_name = 'mobile: gsmVoice'
constants = extract_const_attributes(GsmVoiceState)
if state not in constants.values():
logger.warning(
Expand Down
4 changes: 2 additions & 2 deletions appium/webdriver/extensions/android/power.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def set_power_ac(self, ac_state: str) -> Self:

Android only.

Requires the Appium driver to support the `mobile: powerAC` execute method.
Requires the Appium driver to support the `mobile: powerAc` execute method.

Args:
ac_state: The power ac state to be set. Use `Power.AC_OFF`, `Power.AC_ON`
Expand All @@ -59,7 +59,7 @@ def set_power_ac(self, ac_state: str) -> Self:
Returns:
Union['WebDriver', 'Power']: Self instance
"""
ext_name = 'mobile: powerAC'
ext_name = 'mobile: powerAc'
args = {'state': ac_state}
self.execute_script(ext_name, args)
return self
1 change: 1 addition & 0 deletions test/unit/webdriver/device/gsm_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,5 @@ def test_set_gsm_voice(self):
assert isinstance(driver.set_gsm_voice(GsmVoiceState.ROAMING), WebDriver)

d = get_httpretty_request_body(httpretty.last_request())
assert d['script'] == 'mobile: gsmVoice'
assert d['args'][0]['state'] == GsmVoiceState.ROAMING
2 changes: 1 addition & 1 deletion test/unit/webdriver/device/power_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ def test_set_power_ac(self):
assert isinstance(driver.set_power_ac(Power.AC_ON), WebDriver)

d = get_httpretty_request_body(httpretty.last_request())
assert d['script'] == 'mobile: powerAC'
assert d['script'] == 'mobile: powerAc'
assert d['args'][0]['state'] == Power.AC_ON