Split K8sHelper, add WorkerProvisioner protocol, and add LinuxWorker … - #2110
Open
jshi991 wants to merge 4 commits into
Open
Split K8sHelper, add WorkerProvisioner protocol, and add LinuxWorker …#2110jshi991 wants to merge 4 commits into
jshi991 wants to merge 4 commits into
Conversation
jshi991
force-pushed
the
k8s-worker-provisioner
branch
3 times, most recently
from
August 12, 2026 03:03
84bc66c to
549d886
Compare
jglogan
reviewed
Aug 12, 2026
jglogan
reviewed
Aug 12, 2026
jshi991
force-pushed
the
k8s-worker-provisioner
branch
from
August 13, 2026 00:00
3666cd9 to
5ae84a9
Compare
jglogan
reviewed
Aug 13, 2026
| let containsHelp = fullArgs.contains("-h") || fullArgs.contains("--help") | ||
| if fullArgs.count <= 2 && containsHelp { | ||
| let pluginLoader = try? await createPluginLoader() | ||
| let pluginLoader = try? await Utility.createPluginLoader(log: bootstrapLogger) |
Contributor
There was a problem hiding this comment.
Remove all these changes; they've been merged already.
| var defaultNodeImage: String? { get } | ||
|
|
||
| /// Start the machine identified by `name` before cluster initialisation. | ||
| func provision(name: String, log: Logger) async throws |
Contributor
There was a problem hiding this comment.
Why change NodeProvisioner so that it can only generate a single node configuration?
| /// Called by the executable target to supply the default control-plane provisioner. | ||
| /// The closure receives the parsed CLI values and returns a `NodeProvisioner`. | ||
| /// Set this before `K8sCommand.main()` runs. | ||
| nonisolated(unsafe) public static var makeDefaultProvisioner: |
Contributor
There was a problem hiding this comment.
I'm not sure we need a factory pattern here (see below comment) but if we go this way it might make more sense to create a dedicated prototype for it.
… with role support
jshi991
force-pushed
the
k8s-worker-provisioner
branch
from
August 13, 2026 18:37
5ae84a9 to
ac1e684
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2102