Give in-dyno addon containers unique names - #28
Merged
Conversation
The db/redis test addon containers were created with the fixed names "db" and "redis". Because CodeBuild reuses the Docker daemon across builds, a leftover container from a previous build caused a naming conflict: Conflict. The container name "/db" is already in use... Prefix the addon container names with the (unique) CodeBuild build ID, matching how the buildx builder and test container are already named. The friendly "db"/"redis" names are preserved as network aliases so other containers can still reach the addon by hostname (e.g. DATABASE_URL=postgres://...@db:5432/postgres). Closes #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A client build failed in the prebuild phase with:
CodeBuild reuses the Docker daemon across builds. The in-dyno test addons (
db,redis) were created with fixed container names, so a leftover container from a previous build collides on the next one.Fix
Prefix the addon container names with the (unique) CodeBuild build ID — the same scheme already used for the buildx builder and the test container. The friendly
db/redisnames are preserved as network aliases, so other containers can still reach the addon by hostname (e.g.DATABASE_URL=postgres://...@db:5432/postgres).RunContainergains analiases []stringparameter; the postbuild test container passesnil(it's already uniquely named).Testing
Wrote a throwaway integration test against a real Docker daemon:
dbon the same daemon fails withConflict. The container name "/db" is already in use.dbaddon with unique names (<build-id>-db) and no conflict; thedbnetwork alias still resolves (getent hosts db→172.19.0.2 db), soDATABASE_URL=...@db:5432is unaffected.go test ./...passes.Closes #27