fix(git): stop Production branch dropdown shifting the create-deployment modal - #3180
Merged
Merged
Conversation
Portaling the fixed-position dropdown into <dialog> made it resolve against the dialog containing block, so opening Production branch shifted modal contents (#2790). Append to document.body instead and stopPropagation so outside-click dismiss still works. Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Console (appwrite/console)Project ID: Tip Environment variables can be scoped per function or shared across your project |
Contributor
Greptile SummaryThe PR updates
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "fix(git): detect owning dialog via close..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Body portals sit under showModal() top layer, so the dropdown was unreachable. Keep portaling into the open dialog for stacking, but convert getBoundingClientRect() to dialog-local coordinates — fixed positioning inside the dialog is relative to that box, and viewport coords were what shifted the modal (#2790). Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Svelte slot projection means BranchSelector never sees pink Modal's
dialog-group context, so the dialog portal path never ran. Use
containerEl.closest('dialog') instead so create-deployment menus
still join the showModal() top layer with dialog-local coordinates.
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
ChiragAgg5k
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the layout wiggle when opening the Production branch dropdown inside Create Git deployment (and other dialogs that use
BranchSelector).Cause: The dropdown used
position: fixedbut was portaled into the open<dialog>. Dialogs commonly establish a containing block (transform/filter), sofixedbehaved like absolute inside the dialog and the menu participated in dialog layout — shifting modal contents on open (#2790).Fix: Always portal to
document.body, andstopPropagationon mousedown/click so modal outside-click dismiss does not fire when interacting with the menu.Test Plan
Related PRs and Issues
Fixes #2790
Have you read the Contributing Guidelines on issues?
Yes