Repository navigation
Prepare FocalNet for a public repository - #6
Merged
Merged
Conversation
Drop the yeet.page checkpoint URL so a public clone cannot fetch the derived ONNX. The browser demo now expects a locally exported model, and CI runs the Bun unit tests and bundle. Co-authored-by: Torsten Dittmann <TorstenDittmann@users.noreply.github.com>
TorstenDittmann
marked this pull request as ready for review
September 14, 2026 22:22
|
Restore placeholder generation if FOCALNET_ONNX_URL is set with FOCALNET_ALLOW_DUMMY=1 and the download fails. Pin GitHub Actions in CI to immutable commit SHAs. Co-authored-by: Torsten Dittmann <TorstenDittmann@users.noreply.github.com>
Dummy fallback now covers download and install errors only. After a successful URL install, temp-file unlink is best-effort so a cleanup failure cannot overwrite the real ONNX. Co-authored-by: Torsten Dittmann <TorstenDittmann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crop lab’s default yeet.page URL would have published the derived ONNX the moment this repository went public. That URL was only a demo host. This change makes the public story match the README: source is MIT, checkpoints stay local.
What changed
bun run fetch-modelno longer has a baked-in download URL. It copiesFOCALNET_ONNX, optionally fetchesFOCALNET_ONNX_URL, and can still write a dummy graph for UI layout.bun testandbun run buildnext to the Python job.Local verification
bun test: 20 passedbun run fetch-modelwith no env: exits 1 (No local checkpoint)FOCALNET_ALLOW_DUMMY=1 bun run fetch-model: writes an 18 KB placeholderbun run buildsucceeds with and without an ONNX fileyeet/ yeet.page URLs in the treepytest -q: 53 passedGo-live after merge (GitHub listing; this PR cannot set it):
gh repo edit appwrite/focalnet \ --description "Content-aware image cropping with a compact ONNX importance map and human ranking head" \ --add-topic onnx --add-topic computer-vision --add-topic image-cropping --add-topic appwrite gh repo edit appwrite/focalnet --visibility publicNo homepage: the yeet demo is not the public surface. Leave
.cursor/environment.jsonas the Cloud Agent bootstrap.