Repository navigation
feat: Python SDK update for version 25.0.0 - #159
ChiragAgg5k wants to merge 2 commits into
Conversation
馃數 Tier A 路 Mergeable after minor fixes
Updates the Python SDK to target Appwrite 2.4, adding domains, WAF, passkey, OAuth2, and policy APIs alongside new models and enums. It also updates request handling for multipart uploads and text responses, and revises the changelog and examples for version 25.0.0. 527 of 626 changed files were too large to include in full.
Note Not approving while a bug finding is open: Use mapping defaults for dict-valued fields
Fix with agent prompt### Issue 1
appwrite/models/backup_restoration.py:71
**Use mapping defaults for dict-valued fields**
When `options` is missing, this validator inserts `[]` even though the field is now `Dict[str, Any]`, so Pydantic raises a validation error instead of filling the missing field. The same list default is used for dict-valued fields such as `Message.data`, `Provider.credentials`, `Project.onboarding`, `PasskeyChallenge.publicKey`, `InsightCTA.params`, and WAF rule `config`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.馃搨 Walkthrough 路 7
Reviewed |
| if 'migrationId' not in data and 'migrationid' not in data: | ||
| data['migrationId'] = '' | ||
| if 'options' not in data: | ||
| data['options'] = [] |
There was a problem hiding this comment.
Use mapping defaults for dict-valued fields
When options is missing, this validator inserts [] even though the field is now Dict[str, Any], so Pydantic raises a validation error instead of filling the missing field. The same list default is used for dict-valued fields such as Message.data, Provider.credentials, Project.onboarding, PasskeyChallenge.publicKey, InsightCTA.params, and WAF rule config.
Prompt To Fix With AI
This is a comment left during a code review.
Path: appwrite/models/backup_restoration.py
Line: 71
Comment:
**Use mapping defaults for dict-valued fields**
When `options` is missing, this validator inserts `[]` even though the field is now `Dict[str, Any]`, so Pydantic raises a validation error instead of filling the missing field. The same list default is used for dict-valued fields such as `Message.data`, `Provider.credentials`, `Project.onboarding`, `PasskeyChallenge.publicKey`, `InsightCTA.params`, and WAF rule `config`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.馃煛 Minor 路 bug 路 Reply if this doesn't apply.
|
Superseded: replaced by a passkeys-only minor release. |
This PR contains updates to the Python SDK for version 25.0.0.