Skip to content

fix(ci): run PR workflows when a draft is marked ready for review#488

Merged
rhuanbarreto merged 1 commit into
mainfrom
fix/ci-ready-for-review
Jul 17, 2026
Merged

fix(ci): run PR workflows when a draft is marked ready for review#488
rhuanbarreto merged 1 commit into
mainfrom
fix/ci-ready-for-review

Conversation

@rhuanbarreto

Copy link
Copy Markdown
Contributor

Problem

code-pull-request.yml and dco.yml gate every job on github.event.pull_request.draft == false, but their pull_request triggers only listed [opened, edited, synchronize, reopened]. A PR opened as draft therefore got a run where every job was skipped — which made the "Validate Code" fan-in gate report failure — and marking the PR ready for review never triggered a fresh run, since ready_for_review was not in the trigger list. The PR stayed stuck with a spurious failed/skipped check until an unrelated push. This surfaced on #485, #486, and #487.

Fix

Add ready_for_review to the pull_request trigger types in both workflows, so promoting a draft to ready triggers a run whose jobs actually execute. Two-line diff, nothing else changed.

Validation

  • bun run validate passes (lint, typecheck, format:check, 1558 tests, ADR check, knip, build check)
  • bun run cli check clean: 44/44 rules pass, 0 warnings

Both code-pull-request.yml and dco.yml gate their jobs on
github.event.pull_request.draft == false, but the pull_request trigger
omitted the ready_for_review event type. A PR opened as draft therefore
got a run with every job skipped (and the Validate Code fan-in gate
reported failure), and marking the PR ready never triggered a fresh run,
leaving the PR stuck with a spurious failed check until an unrelated
push. Adding ready_for_review to the trigger types makes both workflows
re-run when a draft is promoted.

Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
@cursor

cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_64a648ae-ba69-4387-99e1-d46b964ae715)

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@rhuanbarreto, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f36b4304-b129-4dcf-9844-b9fbf15631a9

📥 Commits

Reviewing files that changed from the base of the PR and between 0a4ec29 and 9a8423e.

📒 Files selected for processing (2)
  • .github/workflows/code-pull-request.yml
  • .github/workflows/dco.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying archgate-cli with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a8423e
Status: ✅  Deploy successful!
Preview URL: https://43827a6e.archgate-cli.pages.dev
Branch Preview URL: https://fix-ci-ready-for-review.archgate-cli.pages.dev

View logs

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Metric Value
Lines 91.2% (8094 / 8872)
Threshold 90% minimum — met
Platforms Linux + Windows

Full HTML report available in workflow artifacts.

Per-directory breakdown
Directory Coverage Lines
src/commands/ 89.0% 1959 / 2200
src/engine/ 93.7% 1977 / 2111
src/formats/ 98.7% 148 / 150
src/helpers/ 90.9% 4010 / 4411

@rhuanbarreto

Copy link
Copy Markdown
Contributor Author

@coderabbitai approve

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
✅ Action performed

Comments resolved and changes approved.

@rhuanbarreto
rhuanbarreto merged commit ab1fc96 into main Jul 17, 2026
28 checks passed
@rhuanbarreto
rhuanbarreto deleted the fix/ci-ready-for-review branch July 17, 2026 02:41
@archgatebot archgatebot Bot mentioned this pull request Jul 17, 2026
rhuanbarreto pushed a commit that referenced this pull request Jul 17, 2026
# archgate

## [0.50.0](v0.49.0...v0.50.0)
(2026-07-17)

### Features

* **engine:** cache ctx.ast() parse results within a single check run
([#487](#487))
([40b39d3](40b39d3)),
closes [#482](#482)
* **engine:** ctx.findAstNodes() generic AST node collector
([#486](#486))
([f14b73b](f14b73b)),
closes [#483](#483)
* **engine:** support { comments: true } for ctx.ast() Ruby
([#485](#485))
([36b891f](36b891f)),
closes [#484](#484)

### Bug Fixes

* **ci:** run PR workflows when a draft is marked ready for review
([#488](#488))
([ab1fc96](ab1fc96)),
closes [#485](#485)
[#486](#486)

---
This PR was generated with
[simple-release](https://github.com/TrigenSoftware/simple-release).

<details>
<summary>📄 Cheatsheet</summary>
<br>



You can configure the bot's behavior through a pull request comment
using the `!simple-release/set-options` command.

### Command Format

````md
!simple-release/set-options

```json
{
  "bump": {},
  "publish": {}
}
```
````

### Useful Parameters

#### Bump

| Parameter | Type | Description |
|-----------|------|-------------|
| `version` | `string` | Force set specific version |
| `as` | `'major' \| 'minor' \| 'patch' \| 'prerelease'` | Release type
|
| `prerelease` | `string` | Pre-release identifier (e.g., "alpha",
"beta") |
| `firstRelease` | `boolean` | Whether this is the first release |
| `skip` | `boolean` | Skip version bump |
| `byProject` | `Record<string, object>` | Per-project bump options for
monorepos |

#### Publish

| Parameter | Type | Description |
|-----------|------|-------------|
| `skip` | `boolean` | Skip publishing |
| `access` | `'public' \| 'restricted'` | Package access level |
| `tag` | `string` | Tag for npm publication |

### Usage Examples

#### Force specific version

````md
!simple-release/set-options

```json
{
  "bump": {
    "version": "2.0.0"
  }
}
```
````

#### Force major bump

````md
!simple-release/set-options

```json
{
  "bump": {
    "as": "major"
  }
}
```
````

#### Create alpha pre-release

````md
!simple-release/set-options

```json
{
  "bump": {
    "prerelease": "alpha"
  }
}
```
````

#### Publish with specific access and tag

````md
!simple-release/set-options

```json
{
  "bump": {
    "prerelease": "beta"
  },
  "publish": {
    "access": "public",
    "tag": "beta"
  }
}
```
````

### Access Restrictions

The command can only be used by users with permissions:
- repository owner
- organization member
- collaborator

### Notes

- The last comment with `!simple-release/set-options` command takes
priority
- JSON must be valid, otherwise the command will be ignored
- Parameters apply only to the current release execution
- The command can be updated by editing the comment or adding a new one


</details>

<!--
  Please do not edit this comment.
  simple-release-pull-request: true
  simple-release-branch-from: release
  simple-release-branch-to: main
-->

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant