Repository navigation
Locate libcrypt via find_library and raise a clear error if missing - #4843
Open
AmmaarBakshi wants to merge 1 commit into
Open
AmmaarBakshi wants to merge 1 commit into
AmmaarBakshi wants to merge 1 commit into
Conversation
ctypes.CDLL('libcrypt.so') fails on systems that only ship a versioned
soname (e.g. libcrypt.so.2). Resolve the library with
ctypes.util.find_library('crypt'), fall back to 'libcrypt.so', and raise
an ImportError with a readable message if it still cannot be loaded.
Contributor
|
This correct. (And relevant to #4813) I'm not sure if it might not be worth to check |
Torxed
approved these changes
Oct 28, 2026
Torxed
left a comment
Torxed
left a comment
Member
There was a problem hiding this comment.
Not sure if this could cause issues down the line, but as it stands, both /usr/lib/libcrypt.so and /usr/lib/libcrypt.so.2 currently point to libcrypt.so.2.0.0 so there should be no harm in doing this.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctypes.CDLL('libcrypt.so') fails on systems that only ship a versioned soname (e.g. libcrypt.so.2). Resolve the library with ctypes.util.find_library('crypt'), fall back to 'libcrypt.so', and raise an ImportError with a readable message if it still cannot be loaded.
PR Description:
Tests and Checks