Repository navigation
feat(kvdb): cache the used area end in the sector info cache - #432
Merged
Merged
Conversation
A KV search needs empty_kv to stop early instead of reading the sector chunk by chunk up to its end, but the non-traversal path of read_sector_info() used to cache FAILED_ADDR, so the whole sector was scanned on every search until the first write. Search the used area end once there and cache it, so every later search stops at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A KV search needs empty_kv to stop early instead of reading the sector chunk by chunk up to its end, but the non-traversal path of read_sector_info() used to cache FAILED_ADDR, so the whole sector was scanned on every search until the first write. Search the used area end once there and cache it, so every later search stops at it.