Repository navigation
test(nativ): coverage script and floors, tests for the service worker, routes and utils modules - #272
Merged
Merged
Conversation
…, routes and utils modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
packages/nativran its tests with no coverage report, while the game app, the backend and the rules engine already report coverage. This addstest:coverage(@vitest/coverage-v84.1.12, the version the game app uses) with floors set just under today's totals. The CI gate runstest:coverageinstead oftestfor any package that has the script, so the floor gates merges with no workflow change.src/shell/service-worker-shell.tsis left out of coverage. It importsvirtual:nativ/pwa-register, which only the nativ Vite plugin resolves, so the coverage pass cannot load it outside an app build.It also adds unit tests for the three least covered folders by lines.
components/drawerwas also at 0%, but it is a large gesture engine and is better covered in its own PR.sw/(service worker routes, strategies, lifecycle, warm-up)routes/(rootRoute)utils/(cn,clamp, platform checks, vibrate polyfill)Floors: lines, branches, functions and statements all at 14 (measured: 15.00 / 14.52 / 14.85 / 14.61). These changes only add tests. No source behaviour changes.
How to verify
UI quality gate
Does not apply: these changes only add tests and config, with no rendered UI.