Repository navigation
fix(deps): the lockfile resolves patched seroval, glob and minimatch - #541
Merged
Merged
Conversation
arrzdev
force-pushed
the
fix/dependabot-alerts-3885
branch
from
November 1, 2026 18:49
42a5e82 to
1e868d7
Compare
arrzdev
marked this pull request as ready for review
November 1, 2026 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four packages in
pnpm-lock.yamlresolved versions with published advisories. All four are runtime dependencies of adaptv.@tanstack/router-core's own^1.6.7range. The router is not bumped.filelist>minimatchoverride.The overrides live in
pnpm-workspace.yaml, with a comment on each entry. The comment says why the entry is there and when to drop it.API compatibility:
globSyncand rimraf calls onlyglob/globSync. Both exist unchanged in glob 14.minimatch.match, which minimatch 11 still exports. filelist is reached only through ejs's jake CLI, and ejs's library never requires it.About deepmerge: it is reached only through
@rollup/plugin-node-resolve(inside workbox-build). There it merges the plugin's own build options at service-worker build time, and no untrusted input reachesmergeObject.Reproduce:
Verify:
Results on this branch:
pnpm gate: green. 338 test files passed (5011 tests), and build:check passed.pnpm --dir playground test:e2e:sw --project=chromium: 28 passed, 5 skipped. This suite exercises the workbox precache build, which uses glob.pnpm --dir playground test:e2e --project=chromium: 466 passed, 5 skipped, 3 failed. The 3 failures were Chrome's "Socket path too long" atbrowserType.launchunder the VM's longTMPDIR. They passed on a re-run ofe2e/app-state.spec.tsande2e/browser.spec.tswith a shortTMPDIR(7 passed, 1 skipped). This suite covers SSR, where seroval serialises router state.The overrides block sits above
patchedDependencies, becausecreate.test.mjsreads every'key': valueline after that key as a patch entry.Also smoke-checked directly with the new versions: filelist
FileList.include()matched 8 files, workbox-buildgetManifest()returned 456 entries, and rimraf{ glob: true }resolved.Tested on: Linux x64, Node 22.23.3, pnpm 11.1.1.
Not tested: macOS/Windows, Android/iOS builds.