Repository navigation
fix(e2e): the sw-node suite leaves subpath.spec.ts to its own subpath build - #543
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm --dir playground test:e2e:sw:allwas always red: its last suite,sw-node, rane2e-sw/subpath.spec.ts.Root cause: a config match, not a node-server bug.
subpath.spec.ts(added in 2670f4c) needs arender: "spa"build under--base /app/, served bye2e-sw/subpath-host.ts; it has its own config,playwright.sw-subpath.config.ts. When it landed,playwright.sw.config.tsandplaywright.sw-spa.config.tsgotsubpath.spec.tsin theirtestIgnore;playwright.sw-node.config.tsdid not. So sw-node ran it against anssrbuild rooted at/, where every/app/URL is outside the app. All 13 failures on main are in that spec; every other spec in sw-node passed.Change:
playwright.sw-node.config.tsaddssubpath.spec.tstotestIgnore, the same way its siblings do. The spec still runs where it can pass, intest:e2e:sw:subpath.Reproduce (main):
Verify (this branch):
Tested on: Linux (WSL2), Node 22, chromium + webkit (Playwright's iPhone 13 device), every suite in
test:e2e:sw:all.Not tested: CI. No workflow runs
sw-nodeorsw-subpathtoday, and this PR leaves the workflows alone.