Expose generic eval runtime#6
Open
olivermt wants to merge 1 commit into
Open
Conversation
Contributor
|
That PR is merged, not sure what this changes (or really why, as the description is light on that context), can you pull into this branch? |
Contributor
Author
|
I thought there was a dependency but I can't find it now, so to be honest I am not quite sure what I meant :S |
zachdaniel
reviewed
Jun 30, 2026
| end | ||
|
|
||
| defp eval_manifest_cache_enabled? do | ||
| :persistent_term.get(@eval_manifest_cache_enabled_key, false) |
Contributor
There was a problem hiding this comment.
Why do we need to check in persistent term if it's enabled? I think we could just have like a cache?: true option when generating these. EvalActions would then do it by default (good idea).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AshLua.Evalas a generic runtime API for manifest resolution, docs, and script executionpreload_eval_manifests!/1Checks
mix deps.getmix compileMIX_ENV=test mix testmix check --no-retryBuilds on #5; once that merges, this PR should reduce to the follow-up eval/runtime commit.