fix(tools): route bazel config to vanilla bazel - #1390
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
✨ Aspect Workflows Tasks📅 Thu Aug 13 22:32:16 UTC 2026 ❌ 1 failed task
|
mcook42
force-pushed
the
fix/bazel-config-routing
branch
from
August 13, 2026 16:03
6ae978a to
a369598
Compare
jbedard
approved these changes
Aug 13, 2026
`BAZEL_VERBS` was generated from `bazel help`'s "Available commands" list, which hides `config`. A verb missing from that table is treated as a custom aspect task, so `bazel config` became `aspect config` → `error: unrecognized subcommand 'config'`. The IntelliJ Bazel plugin calls `bazel config --dump_all --output=json` during sync and parses stdout as JSON, so this failed the sync outright. Regenerate from `bazel help completion`'s `BAZEL_COMMAND_LIST`, which includes hidden commands — verified against Bazel 9.0.1, `config` is the sole difference. Record the regeneration recipe and *why* it must not be `bazel help` in the comment, and in tools/bazel.md. The gap also silently degraded the pre-verb disambiguation walk, since KNOWN_VERBS_STR is built from the same table.
Both are generated: .idea/ by the IDE, .bazelbsp/ by the JetBrains Bazel plugin (its injected aspect .bzl files), and both showed as untracked after an IntelliJ sync.
mcook42
force-pushed
the
fix/bazel-config-routing
branch
from
August 13, 2026 22:25
a369598 to
67c8a09
Compare
jbedard
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1370 (fix 3 of 3) . See that PR's description for full context on all three defects found in the same investigation.
BAZEL_VERBSintools/bazelwas generated frombazel help's "Available commands" list, which hidesconfig. A verb missing from that table is treated as a custom aspect task and routed toaspect. The IntelliJ Bazel plugin callsbazel config --dump_all --output=jsonduring sync and parses stdout as JSON, so this failed the sync on its own.The authoritative list is
bazel help completion'sBAZEL_COMMAND_LIST, which includes hidden commands — verified against Bazel 9.0.1,configis the sole difference. The regeneration recipe and why it must not bebazel helpare now recorded in both the script comment andtools/bazel.md:The gap also silently degraded the pre-verb disambiguation walk, since
KNOWN_VERBS_STRis built from the same table.Also ignores
.idea/and.bazelbsp/, both of which are generated by the plugin.Test plan
tools/bazel config --dump_all --output=jsonnow reaches vanilla Bazel's ownconfigsubcommand (Bazel's own "No configurations found" message) instead of the aspect wrapper'sunrecognized subcommand 'config'.