Fixes - #155
Merged
Merged
Conversation
The script was a one-off helper for porting SDK examples between languages. It was never wired into any generate script or workflow and required an openai package that the repo never declared.
Run mypy in strict mode over everything except submodules, which are generated SDKs checked in their own repos, and annotate the scripts that were still untyped so the target passes. Switch black to --extend-exclude, since --exclude replaces its default exclude list and would make it walk the new .mypy_cache directory.
Match changelog headers on whole lines. "## 4.26.4" is a substring of both "## 4.26.4+1" and "## 4.26.41", so a patch release or a double-digit month silently suppressed the next entry, leaving a Dart package version with no matching CHANGELOG entry. Validate year, month and patch in argparse and check every file the release touches exists before the first write. "new-version.py 26 13" used to rewrite two configs and then die on ValueError, leaving the remaining seven SDKs on the old version. Update the Swift changelog alongside the Dart one. It had already fallen a release behind the Swift config.
The C# and Java splitters exited 0 having split nothing when the copyright banner regex found no matches, so a changed banner would ship un-split API files and surface much later as a compile error. Raise instead, and replace the equivalent assert in the PHP splitter so python -O cannot strip it.
The config paths, the release file list and the nine set_*_version functions repeated the same nine SDKs four times over. Adding an SDK meant touching all four. Collapse them into one SDKS tuple. The config is always codegen/config-<name>.json and the changelog, where there is one, is always submodules/<name>/CHANGELOG.md, so the name derives both, and the version format defaults to the plain YY.M.P that seven of the nine use. Adding an SDK is now one line.
ivankamkin
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.